feat: support different configure between hokusai v1 and v2 #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
artsyjian
changed the title
|
will test dev orb before merging. |
joeyAghion
approved these changes
Oct 12, 2023
artsyjian
commented
Oct 12, 2023
artsyjian
changed the title
This was referenced Oct 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hokusai v2 will soon be released with a breaking change on
hokusai configurecommand. If we simply release Hokusai v2, theconfigurecommand in this Orb will break. Therefore, update this Orb to work with v2 while still supporting v1. After v2 is released we will come back here to remove v1 logiic.