This allows us to set LANG= in vconsole for keymap negotiation during crypt-unlock #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm holding off on this one until I figure out why it doesn't work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #596 by explicitly setting
LANG=in/etc/vconsole.conf.Not sure why this is needed, but is apparently a known "weird" glitch.
And just to be clear, it's not always required. But it's hard to tell when it is.
And adding this shouldn't cause any other issues. The drawback is that we generate and run
mkinitcpiotwice.I'm contemplating evaluating sd-encrypt hook instead. But saving that for later.