Skip to content

Fix issue with RocksDB producing tiny SST files #22181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kvahed wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

Fix issue with RocksDB producing tiny SST files #22181

kvahed wants to merge 1 commit into from
+4 −2

Conversation

@kvahed
Copy link
Contributor

@kvahed kvahed commented Dec 11, 2025 •
edited by cursor bot
Loading

Scope & Purpose

Prevent RocksDB from creating tiny SST files for large number of databases, collections

  • 💩 Bugfix
  • 🍕 New feature
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification

Checklist

  • Tests
    • Regression tests
    • C++ Unit tests
    • integration tests
    • resilience tests
  • 📖 CHANGELOG entry made
  • 📚 documentation written (release notes, API changes, ...)
  • Backports
    • Backport for 3.12.0: (Please link PR)
    • Backport for 3.11: (Please link PR)
    • Backport for 3.10: (Please link PR)

Related Information

(Please reference tickets / specification / other PRs etc)

  • Docs PR:
  • Enterprise PR:
  • GitHub issue / Jira ticket:
  • Design document:

Note

Disables default partitioning of document column family SST files to prevent proliferation of tiny SSTs and updates the CHANGELOG.

  • RocksDB options:
    • Default RocksDBOptionFeature setting _partitionFilesForDocumentsCf changed from true to false, effectively disabling --rocksdb.partition-files-for-documents by default to avoid tiny .sst files.
  • CHANGELOG:
    • Add entry noting fix for RocksDB creating tiny SST files.

Written by Cursor Bugbot for commit 4f51f2d. This will update automatically on new commits. Configure here.

@kvahed kvahed requested review from jbajic and mpoeter December 11, 2025 12:53
@kvahed kvahed self-assigned this Dec 11, 2025
@kvahed kvahed added 3 RocksDB Storage engine related 3 Compaction Related to the rocksdb compaction labels Dec 11, 2025
@cla-bot cla-bot bot added the cla-signed label Dec 11, 2025
neunhoef
neunhoef approved these changes Dec 11, 2025
View reviewed changes
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neunhoef neunhoef neunhoef approved these changes

@mpoeter mpoeter Awaiting requested review from mpoeter

@jbajic jbajic Awaiting requested review from jbajic

Assignees

@kvahed kvahed

Labels

3 Compaction Related to the rocksdb compaction 3 RocksDB Storage engine related cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kvahed @neunhoef