[COR-50] Introduce thread-local leasers for builders and strings #22176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Should add a test that at least tickles TSAN when run. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on December 28
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
markuspf
changed the title
markuspf
force-pushed
the
bug-fix/thread-local-leasers
branch
from
6db4315 to
cdcf639
Compare
Contributor
Author
|
Should also measure performance implications. At the moment there is only a very small number of leasable builders/string available per thread, as opposed to the previously unbounded number per transaction. |
markuspf
force-pushed
the
bug-fix/thread-local-leasers
branch
from
a4e360a to
46a60a2
Compare
mpoeter
reviewed
Dec 15, 2025
markuspf
force-pushed
the
bug-fix/thread-local-leasers
branch
from
371ba8d to
89a2ec8
Compare
markuspf
force-pushed
the
bug-fix/thread-local-leasers
branch
from
a1709b0 to
4278066
Compare
mpoeter
reviewed
Dec 15, 2025
mpoeter
approved these changes
Dec 16, 2025
Contributor
Author
|
For the record: simple performance tests did not show any effect of this change on performance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Introduces thread-local leasers for velocypack::Builder and std::string.
This also addresses a problem with
async-prefetchwhere builders and strings were leased through the transaction context, which is not meant to be acceessed concurrently.Fixes #22158 and other issues with
async-prefetchNote
Introduce thread-local leasers for Builder and std::string and refactor transaction leasers to use them, fixing async-prefetch concurrency issues and adding targeted tests.
ThreadLocalLeaser: AddBasics/ThreadLocalLeaser.hwith thread-local pooling for reusable objects; typedefsThreadLocalBuilderLeaserandThreadLocalStringLeaser.ThreadLocalLeaserTest.cppcovering leasing, stash behavior, moves, and cross-thread handoff.transaction::StringLeaserandtransaction::BuilderLeasernow useThreadLocal*Leaser(release/acquire/get); remove context-based leasing/destructors/clear/steal.Helpers.cpp/.h,Methods.cpp(drop explicit_replicationData.clear()), and helpers to new APIs.tests/Mocks/PhysicalCollectionMock.cppto usebuilder.release().aql-async-prefetch-leaser-reuse.jsto stress async-prefetch concurrency.Written by Cursor Bugbot for commit c0d5590. This will update automatically on new commits. Configure here.