[COR-57] Remove extractCollection helper from step #22166
+21
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markuspf
changed the title
jvolmer
approved these changes
Dec 9, 2025
Comment on lines
29
to
34
| [[nodiscard]] auto extractCollectionName( | ||
| velocypack::HashedStringRef const& idHashed) | ||
| -> ResultT<std::pair<std::string, size_t>>; | ||
|
|
||
| [[nodiscard]] auto extractCollectionNameOrThrow( | ||
| velocypack::HashedStringRef const& vertexRef) -> std::string; |
Contributor
There was a problem hiding this comment.
probably personal taste: could also be member functions of VertexRef but his is also fine.
markuspf
force-pushed
the
chore/unify-vertex-ref
branch
from
94c2ae2 to
4e40c07
Compare
markuspf
force-pushed
the
chore/remove-extract-collection-helper-from-step
branch
from
e36b2c6 to
ae01274
Compare
markuspf
force-pushed
the
chore/remove-extract-collection-helper-from-step
branch
from
a42946e to
65b6bad
Compare
markuspf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Removes some code duplication. Requires #22165 to be merged first, and has an enterprise counterpart, https://github.com/arangodb/enterprise/pull/1564
Note
Replaces per-step collection-name extraction with VertexRef::collectionName, updates PathValidator accordingly, removes redundant getCollectionName/extract helpers, and wires new VertexRef.cpp into build.
VertexRef::collectionName()and new implementation fileGraph/Types/VertexRef.cpp; include inGraph/Types/CMakeLists.txt.step.getVertex().collectionName()inPathValidator::evaluateVertexRestrictionwith error propagation.getCollectionName()andBaseStep::extractCollectionName; adjustClusterProviderStep,SingleServerProviderStep, and testMockGraphProvider::Stepto rely onVertexRefAPIs.WeightedTwoSidedEnumerator(setForbidden*signatures,searchDonedeclaration).Written by Cursor Bugbot for commit 5abb820. This will update automatically on new commits. Configure here.