Skip to content

[COR] Unify Provider Steps #22144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
markuspf wants to merge 9 commits into from
Closed

[COR] Unify Provider Steps #22144

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bf89601
Remove cursorID from Steps
markuspf Nov 27, 2025
9a74fbf
Use type alias and remove unused function
markuspf Nov 28, 2025
12fa0a1
Simplify Step code
markuspf Nov 28, 2025
17c8d09
Clean up includes
markuspf Nov 28, 2025
e4abe36
Simplify Step code
markuspf Nov 28, 2025
f8f0104
Simplify Step code
markuspf Nov 28, 2025
2d53f04
Simplify Step code even more
markuspf Nov 28, 2025
d7e1d2c
Fix tests
markuspf Nov 28, 2025
b21a045
restore isValid
markuspf Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove cursorID from Steps
  • Loading branch information
@markuspf
markuspf committed Nov 27, 2025
commit bf89601289f80ee9fd94cabf1213d090e0f58df6
3 changes: 1 addition & 2 deletions arangod/Graph/Providers/SingleServerProvider.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,7 @@ auto SingleServerProvider<Step>::expand(

EdgeDocumentToken edgeToken{neighbour.eid};
callback(Step{id, std::move(edgeToken), previous, step.getDepth() + 1,
_opts.weightEdge(step.getWeight(), edge),
neighbour.cursorId});
_opts.weightEdge(step.getWeight(), edge)});
// TODO [GraphRefactor]: Why is cursorID set, but never used?
// Note: There is one implementation that used, it, but there is a high
// probability we do not need it anymore after refactoring is complete.
Expand Down
2 changes: 1 addition & 1 deletion arangod/Graph/Steps/SingleServerProviderStep.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ SingleServerProviderStep::SingleServerProviderStep(VertexType v,
SingleServerProviderStep::SingleServerProviderStep(VertexType v,
EdgeDocumentToken edge,
size_t prev, size_t depth,
double weight, size_t)
double weight)
: BaseStep(prev, depth, weight), _vertex(v), _edge(std::move(edge)) {}

SingleServerProviderStep::~SingleServerProviderStep() = default;
Expand Down
2 changes: 1 addition & 1 deletion arangod/Graph/Steps/SingleServerProviderStep.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ class SingleServerProviderStep : public arangodb::graph::BaseStep {
SingleServerProviderStep(VertexType v);
SingleServerProviderStep(VertexType v, EdgeDocumentToken edge, size_t prev);
SingleServerProviderStep(VertexType v, EdgeDocumentToken edge, size_t prev,
size_t depth, double weight, size_t);
size_t depth, double weight);
SingleServerProviderStep(VertexType v, size_t depth, double weight = 0.0);
~SingleServerProviderStep();

Expand Down