Update nodejs to LTS version (OctoLinker#775)

* Update nodejs to LTS version * Update snapshot
apryl489 · Jan 17, 2020 · afdff46 · afdff46
1 parent 84f2b36
commit afdff46
Show file tree

Hide file tree

Showing 5 changed files with 37 additions and 56 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -7,7 +7,7 @@ jobs:
     - uses: actions/checkout@v1
     - uses: actions/setup-node@v1
       with:
-        node-version: '10.x'
+        node-version: '12.x'
     - run: npm ci
     - run: npm test
       env:

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -10,7 +10,7 @@ jobs:
     - uses: actions/checkout@v1
     - uses: actions/setup-node@v1
       with:
-        node-version: '10.x'
+        node-version: '12.x'
     - run: npm ci
     - run: npm run build
     - run: 'npm run release'

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
   "name": "OctoLinker",
   "version": "5.2.6",
   "engines": {
-    "node": ">=8.0.0"
+    "node": ">=12.0.0"
   },
   "scripts": {
     "lint": "eslint .",

diff --git a/packages/helper-normalise-resolver-results/__snapshots__/test.js.snap b/packages/helper-normalise-resolver-results/__snapshots__/test.js.snap
@@ -1,39 +1,18 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`normaliseResolverResults converts [object Object] 1`] = `
+exports[`normaliseResolverResults converts [
+  '{BASE_URL}/foo/bar/blob/master/file.js',
+  '{BASE_URL}/foo/bar/blob/master/file.js'
+] 1`] = `
 Array [
   Object {
-    "registry": "npm",
-    "target": "foo",
-    "type": "registry",
-  },
-]
-`;
-
-exports[`normaliseResolverResults converts {BASE_URL}/file.js 1`] = `
-Array [
-  Object {
-    "target": "https://github.com/file.js",
-    "type": "ping",
-  },
-]
-`;
-
-exports[`normaliseResolverResults converts {BASE_URL}/foo/bar/blob/1ab8cfd3b65d3b43335130d6cefbf8c62482680f/file.js 1`] = `
-Array [
-  Object {
-    "branch": "1ab8cfd3b65d3b43335130d6cefbf8c62482680f",
+    "branch": "master",
     "path": "file.js",
     "repo": "bar",
     "type": "internal-link",
-    "url": "https://github.com/foo/bar/blob/1ab8cfd3b65d3b43335130d6cefbf8c62482680f/file.js",
+    "url": "https://github.com/foo/bar/blob/master/file.js",
     "user": "foo",
   },
-]
-`;
-
-exports[`normaliseResolverResults converts {BASE_URL}/foo/bar/blob/master/file.js 1`] = `
-Array [
   Object {
     "branch": "master",
     "path": "file.js",
@@ -45,7 +24,7 @@ Array [
 ]
 `;
 
-exports[`normaliseResolverResults converts {BASE_URL}/foo/bar/blob/master/file.js 2`] = `
+exports[`normaliseResolverResults converts [ '{BASE_URL}/foo/bar/blob/master/file.js' ] 1`] = `
 Array [
   Object {
     "branch": "master",
@@ -58,16 +37,40 @@ Array [
 ]
 `;
 
-exports[`normaliseResolverResults converts {BASE_URL}/foo/bar/blob/master/file.js,{BASE_URL}/foo/bar/blob/master/file.js 1`] = `
+exports[`normaliseResolverResults converts { registry: 'npm', target: 'foo' } 1`] = `
 Array [
   Object {
-    "branch": "master",
+    "registry": "npm",
+    "target": "foo",
+    "type": "registry",
+  },
+]
+`;
+
+exports[`normaliseResolverResults converts {BASE_URL}/file.js 1`] = `
+Array [
+  Object {
+    "target": "https://github.com/file.js",
+    "type": "ping",
+  },
+]
+`;
+
+exports[`normaliseResolverResults converts {BASE_URL}/foo/bar/blob/1ab8cfd3b65d3b43335130d6cefbf8c62482680f/file.js 1`] = `
+Array [
+  Object {
+    "branch": "1ab8cfd3b65d3b43335130d6cefbf8c62482680f",
     "path": "file.js",
     "repo": "bar",
     "type": "internal-link",
-    "url": "https://github.com/foo/bar/blob/master/file.js",
+    "url": "https://github.com/foo/bar/blob/1ab8cfd3b65d3b43335130d6cefbf8c62482680f/file.js",
     "user": "foo",
   },
+]
+`;
+
+exports[`normaliseResolverResults converts {BASE_URL}/foo/bar/blob/master/file.js 1`] = `
+Array [
   Object {
     "branch": "master",
     "path": "file.js",