Remove link indicator option to simplify things

apryl489 · Jan 15, 2018 · 5db577f · 5db577f
1 parent 31ee7cb
commit 5db577f
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 13 deletions.
diff --git a/packages/core/options/page.js b/packages/core/options/page.js
@@ -51,13 +51,6 @@ class App extends Component {
           checked={state.newWindowActive}
           onClick={linkState(this, 'newWindowActive')}
         />
-        <Checkbox
-          name="showLinkIndicator"
-          label="Line indicator"
-          description="Show an indicator if line contains OctoLinker links."
-          checked={state.showLinkIndicator}
-          onClick={linkState(this, 'showLinkIndicator')}
-        />
         <Checkbox
           name="showUpdateNotification"
           label="Update notification"

diff --git a/packages/core/options/storage.js b/packages/core/options/storage.js
@@ -7,7 +7,6 @@ const store = {};
 const defaults = {
   newWindow: false,
   newWindowActive: true,
-  showLinkIndicator: true,
   showUpdateNotification: true,
   doTrack: true,
 };

diff --git a/packages/helper-insert-link/index.js b/packages/helper-insert-link/index.js
@@ -1,6 +1,5 @@
 import $ from 'jquery';
 import findAndReplaceDOMText from 'findandreplacedomtext';
-import * as storage from './options/storage.js';
 
 const CLASS_NAME = 'octolinker-link';
 const CLASS_INDICATOR = 'octolinker-line-indicator';
@@ -17,10 +16,7 @@ function createLinkElement(text, dataAttr = {}) {
 
   // Add css classes
   linkEl.classList.add(CLASS_NAME);
-
-  if (storage.get('showLinkIndicator')) {
-    linkEl.classList.add(CLASS_INDICATOR);
-  }
+  linkEl.classList.add(CLASS_INDICATOR);
 
   // Add data-* attributes
   for (const key in dataAttr) {