Add flag to use producer context as consumer parent #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unflxw
approved these changes
Oct 7, 2024
|
@Steffen911 Could you make it so that Prettier is happy? 😅 |
|
@unflxw It should be happy now 😄 |
unflxw
added a commit
that referenced
this pull request
Oct 8, 2024
Some tweaks to the changes introduced in #11. Rename the config option to `useProducerSpanAsConsumerParent` (that is, `s/Context/Span`) to use language that is more familiar to casual OpenTelemetry users. Rewrite the config option description to describe what happens with and without the config option. Rearrange the instrumentation to move logic branches out of the span creation function.
unflxw
added a commit
that referenced
this pull request
Oct 8, 2024
Some tweaks to the changes introduced in #11. Rename the config option to `useProducerSpanAsConsumerParent` (that is, `s/Context/Span`) to use language that is more familiar to casual OpenTelemetry users. Rewrite the config option description to describe what happens with and without the config option. Rearrange the instrumentation to move logic branches out of the span creation function.
unflxw
added a commit
that referenced
this pull request
Oct 8, 2024
Some tweaks to the changes introduced in #11. Rename the config option to `useProducerSpanAsConsumerParent` (that is, `s/Context/Span`) to use language that is more familiar to casual OpenTelemetry users. Rewrite the config option description to describe what happens with and without the config option. Rearrange the instrumentation to move logic branches out of the span creation function.
unflxw
added a commit
that referenced
this pull request
Oct 8, 2024
Some tweaks to the changes introduced in #11. Rename the config option to `useProducerSpanAsConsumerParent` (that is, `s/Context/Span`) to use language that is more familiar to casual OpenTelemetry users. Rewrite the config option description to describe what happens with and without the config option. Rearrange the instrumentation to move logic branches out of the span creation function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #10
What
Adds a new
useProducerContextAsConsumerParentthat defaults to false. When set to true, the consumer trace uses the context of the producer as its active context, i.e. it keeps the same traceId. In that case, there is no link to the producer span.