Automatically ignore Rails' health-check #1321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loaders can set config defaults. If more than one loader set a config option that contains an array, they would overwrite each other. I think it's a good default to merge array values from loaders. This will prevent options like `ignore_actions` from being overwritten by another loader, and reported actions that should be ignored.
tombruijn
force-pushed
the
ignore-rails-healthcheck
branch
from
2a1dc55 to
dfdfd53
Compare
Adds the `Rails::HealthController#show` endpoint to the default `ignore_actions` config by adding it to the Railtie loader defaults. Suggested by a customer in: https://app.intercom.com/a/inbox/yzor8gyw/inbox/shared/unassigned/conversation/16410700366724#part_id=comment-16410700366724-21909575460 Co-authored-by: Noemi <[email protected]>
In the diagnose CLI spec the Railtie config defaults would be set twice, failing the specs. This was because the spec only checked beforehand if the MyApp constant was present or not, which it is most of the time in this spec. Now also check if the app is already initialized, so the Railtie isn't triggered again, and then trigger it manually.
tombruijn
force-pushed
the
ignore-rails-healthcheck
branch
from
dfdfd53 to
4aaac06
Compare
This is a message from the daily scheduled checks. |
unflxw
approved these changes
Oct 28, 2024
Contributor
unflxw
left a comment
unflxw
left a comment
There was a problem hiding this comment.
This approach makes a lot of sense to me 🎉 Thank you for taking on this task!
Contributor
|
This is great! When will this be released 🤞 ? |
Member
Author
|
Soon! I want to get some other PRs merged as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge array option values from loaders
Loaders can set config defaults. If more than one loader set a config option that contains an array, they would overwrite each other. I think it's a good default to merge array values from loaders. This will prevent options like
ignore_actionsfrom being overwritten by another loader, and reported actions that should be ignored.Automatically ignore Rails' health-check
Adds the
Rails::HealthController#showendpoint to the defaultignore_actionsconfig by adding it to the Railtie loader defaults.Suggested by a customer in: https://app.intercom.com/a/inbox/yzor8gyw/inbox/shared/unassigned/conversation/16410700366724#part_id=comment-16410700366724-21909575460
Fix duplicate Railtie default config in specs
In the diagnose CLI spec the Railtie config defaults would be set twice, failing the specs.
This was because the spec only checked beforehand if the MyApp constant was present or not, which it is most of the time in this spec. Now also check if the app is already initialized, so the Railtie isn't triggered again, and then trigger it manually.