Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement improve mbps option stability and performance #3

Merged
Prev Previous commit
Next Next commit
Merge branch 'master' into Enhancement_improve_--mbps_option_stabilit…
…y_and_performance

Conflicts:
	src/Makefile.am
	src/send_packets.c
	src/sleep.c
	src/sleep.h
	src/tcpreplay.c
  • Loading branch information
fklassen committed Dec 2, 2013
commit 7513447313dc4f6a791f9e959772cb7b624d1331
4 changes: 2 additions & 2 deletions configure
Original file line number Diff line number Diff line change
Expand Up @@ -23248,9 +23248,9 @@ Please see: http://tcpreplay.synfin.net/trac/ticket/142 for more details" >&2;}

*-*-cygwin)
{ $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: Windows/Cygwin support is still somewhat experimental.
Please report any bugs! http://tcpreplay.synfin.net/trac/newticket" >&5
Please report any bugs! http://tcpreplay.synfin.net/trac/newticket" >&5
$as_echo "$as_me: WARNING: Windows/Cygwin support is still somewhat experimental.
Please report any bugs! http://tcpreplay.synfin.net/trac/newticket" >&2;}
Please report any bugs! http://tcpreplay.synfin.net/trac/newticket" >&2;}
;;
esac

1 change: 1 addition & 0 deletions docs/CHANGELOG
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
$Id$

??/??/2013 Version 3.5.0
- Enhance accuracy and performance of --mbps option (appneta #2)
- Add netmap injector (appneta #1)
- Add --sleepmode option to handle high precision timing (#421)
- Update URL's to point to new tcpreplay website (#430)
Expand Down
4 changes: 2 additions & 2 deletions src/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ tcprewrite.1: tcprewrite_opts.def tcpedit/tcpedit_opts.def
@AUTOGEN@ -T agman1.tpl $(opts_list) tcprewrite_opts.def

tcpreplay-edit.1: tcpreplay_opts.def
@AUTOGEN@ -T agman1.tpl $(opts_list) -DTCPREPLAY_EDIT -DTCPREPLAY_EDIT_MAN tcpreplay_opts.def
@AUTOGEN@ -T agman1.tpl $(opts_list) @NETMAPFLAGS@ -DTCPREPLAY_EDIT -DTCPREPLAY_EDIT_MAN tcpreplay_opts.def

tcpreplay.1: tcpreplay_opts.def
@AUTOGEN@ -T agman1.tpl $(opts_list) tcpreplay_opts.def
@AUTOGEN@ -T agman1.tpl $(opts_list) @NETMAPFLAGS@ tcpreplay_opts.def

tcpbridge.1: tcpbridge_opts.def tcpedit/tcpedit_opts.def
@AUTOGEN@ -T agman1.tpl $(opts_list) tcpbridge_opts.def
Expand Down
12 changes: 0 additions & 12 deletions src/sleep.c
Original file line number Diff line number Diff line change
Expand Up @@ -159,17 +159,6 @@ do_sleep(struct timeval *time, struct timeval *last, int len, int accurate,
return;
}

/* also an accelerator, but exposed externally to avoid expensive "now" timestamp */
if (*skip_timestamp) {
if (len < skip_length) {
skip_length -= len;
return;
}

skip_length = 0;
*skip_timestamp = 0;
}

/*
* pps_multi accelerator. This uses the existing send accelerator above
* and hence requires the funky math to get the expected timings.
Expand Down Expand Up @@ -358,7 +347,6 @@ do_sleep(struct timeval *time, struct timeval *last, int len, int accurate,
memcpy(&nap_this_time, &(options.maxsleep), sizeof(struct timespec));
}

SLEEP_NOW:
dbgx(2, "Sleeping: " TIMESPEC_FORMAT, nap_this_time.tv_sec, nap_this_time.tv_nsec);

/* don't sleep if nap = {0, 0} */
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.