Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial travis-ci support #263

Merged
merged 1 commit into from
Feb 26, 2017
Merged

initial travis-ci support #263

merged 1 commit into from
Feb 26, 2017

Conversation

chipitsine
Copy link
Contributor

please add this project to https://travis-ci.org

@fklassen
Copy link
Member

fklassen commented Nov 1, 2016

Thanks for the PR.

I am a bit worried about the rights I give to Travis CI. It seems I have to give the world to all repos, including private ones. We trust GitHub with our private repos, but don't have that trust with Travis.

I sent an email to GitHub support. They say Travis gets right to all repos, both public and private. They don't have access to private sources. GH does not vouch for vendors who I give permissions to. So, risk is on my end.

I will hold onto this PR until I can do more investigation.

@chipitsine
Copy link
Contributor Author

according to https://docs.travis-ci.com/user/github-oauth-scopes/ travis-ci itself is granted a very limited subset of permissions.

what exactly are you afraid of ?

@fklassen
Copy link
Member

After talking to GH Support, realize that Travis has too much access to my private repos if I use my primary account. I set up my secondary account to have outside collaborator access. This allows me to give Travis access to only Tcpreplay and no other repos.

@fklassen fklassen merged commit 5540cbd into appneta:master Feb 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants