Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tap device support for Linux and FreeBSD #207

Merged
merged 1 commit into from
Nov 4, 2015

Conversation

demirten
Copy link
Contributor

@demirten demirten commented Nov 3, 2015

Tap devices must be up and running before using with tcpreplay.

Tap support in Apple devices works a little bit different and it is not compatible with main flow of tcpreplay.

Patch tested in Linux and FreeBSD with different capture files.

@fklassen
Copy link
Member

fklassen commented Nov 3, 2015

Hi Murat. From your comments, can I assume that OS X tun/tap is not supported?

I looked at the code and it looks good to me. I will want to test before merging, but will not be able to work on Tcpreplay until Nov. 23.

@demirten
Copy link
Contributor Author

demirten commented Nov 3, 2015

Yes, I wrote tuntap support for OS X but later I have to remove it.

You need to open /dev/tapX char device and set interface status up in OS X. But all of the procedure must be done within same process. On the other hand, tcpreplay wants to see interfaces on startup, it must be configured before tcpreplay.

So I couldn't find any way to configure tap interface in one process and use it in another process under OS X. If this is possible, adding OS X support will be same as FreeBSD.

fklassen added a commit that referenced this pull request Nov 4, 2015
Tap device support for Linux and FreeBSD
@fklassen fklassen merged commit 4019ed1 into appneta:master Nov 4, 2015
@fklassen
Copy link
Member

fklassen commented Nov 4, 2015

Had a chance to play with this, so I merged. Thanks again for contribution.

@fklassen
Copy link
Member

@demirten I added some comments. If you feel so included, please make updates and send another PR. Tnx, Fred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants