gRPC: Unwrap structpb data value properly #488
Conversation
Missing: recursive objects and lists (arrays)
| notification.Data[k] = x.NumberValue | ||
| } else if x, ok := v.GetKind().(*structpb.Value_BoolValue); ok { | ||
| notification.Data[k] = x.BoolValue | ||
| } |
There was a problem hiding this comment.
what about other types:list, null, struct? may be add some logging for else cases?
There was a problem hiding this comment.
That's why the PR is on hold. I am no expert in Go, which is why I need help from you.
NullValue and ListValue might be easy. However, structs seem to be difficult for me.
|
Hi, looks like there will be new AsMap() function available with the next protobuf release solving this problem: package structpb Found in this issue golang/protobuf#370 linking to the commit https://go-review.googlesource.com/c/protobuf/+/225298/ also for sake of completeness, here is an example how it could have been done with above approach: |
|
@SmartArray thank you for your fix! I created new PR #638 with AsMap() function |
appleboy
force-pushed
the
master
branch
2 times, most recently
from
60a7a68 to
2c29b4b
Compare
This PR fixes the issue seen in #418.
At least this is something we can build on. But support for recursive objects, lists and nullValues needs to be added before we can merge this in master.