Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue of Method normalize with return type '' is different to return type 'ArrayObject|array<array-key, mixed>|null|scalar' of inherited method NormalizerInterface::normalize #390

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Fixes issue of Method normalize with return type '' is different to return type 'ArrayObject|array<array-key, mixed>|null|scalar' of inherited method NormalizerInterface::normalize #390

merged 3 commits into from
Oct 22, 2024

Conversation

kedarkhaire
Copy link
Collaborator

Fixes #383

@kedarkhaire
Fixes issue of Method normalize with return type '' is different to r…
df6f2a1 
…eturn type 'ArrayObject|array<array-key, mixed>|null|scalar' of inherited method NormalizerInterface::normalize
@kedarkhaire kedarkhaire added this to the 4.0.0 milestone Oct 18, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.68%. Comparing base (d90650c) to head (df6f2a1).

Files with missing lines Patch % Lines
.../Api/ApigeeX/Normalizer/RatePlanRateNormalizer.php 0.00% 1 Missing ⚠️
...rmalizer/LegalEntityReportDefinitionNormalizer.php 0.00% 1 Missing ⚠️
src/Normalizer/CredentialProductNormalizer.php 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                4.x     #390   +/-   ##
=========================================
  Coverage     86.68%   86.68%           
  Complexity     1737     1737           
=========================================
  Files           343      343           
  Lines          4220     4220           
=========================================
  Hits           3658     3658           
  Misses          562      562
Flag Coverage Δ
unittests 86.68% <91.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../ApigeeX/Normalizer/AcceptedRatePlanNormalizer.php 100.00% <100.00%> (ø)
...rc/Api/ApigeeX/Normalizer/ApiProductNormalizer.php 100.00% <100.00%> (ø)
...pigeeX/Normalizer/AppGroupMembershipNormalizer.php 100.00% <100.00%> (ø)
src/Api/ApigeeX/Normalizer/AppNormalizer.php 100.00% <100.00%> (ø)
...c/Api/ApigeeX/Normalizer/BillingTypeNormalizer.php 100.00% <100.00%> (ø)
src/Api/ApigeeX/Normalizer/RatePlanNormalizer.php 70.00% <100.00%> (ø)
...i/ApigeeX/Normalizer/RatePlanNormalizerFactory.php 100.00% <100.00%> (ø)
.../ApigeeX/Normalizer/StandardRatePlanNormalizer.php 100.00% <100.00%> (ø)
.../Management/Normalizer/AppCredentialNormalizer.php 100.00% <100.00%> (ø)
src/Api/Management/Normalizer/AppNormalizer.php 100.00% <100.00%> (ø)
... and 26 more

divya-intelli
divya-intelli approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@divya-intelli divya-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kedarkhaire kedarkhaire merged commit 24210f7 into apigee:4.x Oct 22, 2024
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divya-intelli divya-intelli divya-intelli approved these changes

@giteshk giteshk Awaiting requested review from giteshk

@shishir-intelli shishir-intelli Awaiting requested review from shishir-intelli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kedarkhaire @divya-intelli