-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MINOR] Add Jenkins and AppVeyor badges at README.md #23629
Conversation
This comment has been minimized.
This comment has been minimized.
Hey maybe .. @rxin, @srowen, @felixcheung, @gatorsmile .. WDYT about this? I happened to look around some other projects and thought it's good to do. |
7def52a
to
fe3dc9c
Compare
This comment has been minimized.
This comment has been minimized.
There are a number of badges we could add; which ones might be useful to users or developers? I'm not sure. If one of the Jenkins jobs is running, if one of the Appveyor jobs is passing or not, is that useful info per se? Will number of commits matter much and PyPI downloads? I like the code-quality badges and Travis badge for small projects, to show that it's current and maintained, but those aren't relevant here. I think I might leave these off. |
But for both Jenkins and AppVeyor (I'm okay with getting rid of other badges), we might quickly know if the tests are globally being failed or not. But hmmm I don't feel strongly. I can take them out in a couple of days if there are no other feedback. How about the logo? |
We have the amplab Jenkins for status, but I suppose this is another place you might notice. Is the AppVeyor test reliable enough to report here? I can see adding the build status to give a little more warning if something seems to be wrong. The PyPI downloads and commits doesn't seem as useful. |
Yup, I'm going to take both out, and then gonna take the other out too if there are no more feedback about that. Was wondering how you guys feel about this. |
BTW, I would also just close this if there's not much feedback about the logo as well. It's not something worth if people are not sure or don't particularly prefer - it's just making something pretty. |
Test build #101584 has finished for PR 23629 at commit
|
Test build #101586 has finished for PR 23629 at commit
|
I think the build ones are definitely useful. The rest I don't know how useful it is. |
Test build #101593 has finished for PR 23629 at commit
|
Let me take out the logo too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the build logo
Just in case people might want to take the previous change .. take a look at https://github.com/apache/spark/blob/4938c14f4d23880b477d43a6d83ed7e427cb6c7f/README.md and let me know if anyone prefers this. |
I kinda like the logo too, why not? :) |
Yes .. :). WDYT @cloud-fan, @gatorsmile, @holdenk? Looks there are no particular opinion about that logo itself so far. Take a look at this VS the current proposal. For the former, I referred nodejs and bootstrap BTW, I expected a bit of forth and back since the preference matters here. It's okay to forth and back - easy to fix and revert in this PR. Feel free to let me know if there's any preference. |
adding more people to ask preference @BryanCutler, @viirya, @ueshin, @rdblue, @MaxGekk, @mgaido91, @dongjoon-hyun, @hvanhovell who I have talked with time to time in the Spark community (sorry if this cc was too arbitrary). |
Test build #101607 has finished for PR 23629 at commit
|
Thanks for pinging me @HyukjinKwon . Honestly I prefer the current option. It is a README, so the main goal is to provide general information about the project in the clearest possible way. It is not a marketing window where a logo may be more attractive. |
I don't have strong option about this. One idea is currently two icons looks very similar (showing "build running" and "build passing" with different colors). I can't tell too much info from them (e.g., what difference between two). |
^ if you take a look closely one has AppVeyor logo :D. |
Right. Let me propose just build badges here for now. Let me merge this one in few days as is then. |
I didn't see it in IntelliJ IDEA's markdown visual editor. Saw it when manually opened it in browser. :) |
Merged to master. |
## What changes were proposed in this pull request? This PR adds Jenkins build and AppVeyor build badges Take a look at https://github.com/apache/spark/blob/cc24b9e0b35e947e97b47ca9d1b350bb37148b41/README.md ## How was this patch tested? Manually tested by `grip`. Closes apache#23629 from HyukjinKwon/minor-badges. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
What changes were proposed in this pull request?
This PR adds Jenkins build and AppVeyor build badges
Take a look at https://github.com/apache/spark/blob/cc24b9e0b35e947e97b47ca9d1b350bb37148b41/README.md
How was this patch tested?
Manually tested by
grip
.