Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Add Jenkins and AppVeyor badges at README.md #23629

Closed
wants to merge 3 commits into from

Conversation

HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Jan 23, 2019

What changes were proposed in this pull request?

This PR adds Jenkins build and AppVeyor build badges

Take a look at https://github.com/apache/spark/blob/cc24b9e0b35e947e97b47ca9d1b350bb37148b41/README.md

How was this patch tested?

Manually tested by grip.

@HyukjinKwon

This comment has been minimized.

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Jan 23, 2019

Hey maybe .. @rxin, @srowen, @felixcheung, @gatorsmile .. WDYT about this? I happened to look around some other projects and thought it's good to do.

@HyukjinKwon

This comment has been minimized.

README.md Outdated Show resolved Hide resolved
@srowen
Copy link
Member

srowen commented Jan 23, 2019

There are a number of badges we could add; which ones might be useful to users or developers? I'm not sure. If one of the Jenkins jobs is running, if one of the Appveyor jobs is passing or not, is that useful info per se? Will number of commits matter much and PyPI downloads? I like the code-quality badges and Travis badge for small projects, to show that it's current and maintained, but those aren't relevant here. I think I might leave these off.

@HyukjinKwon
Copy link
Member Author

But for both Jenkins and AppVeyor (I'm okay with getting rid of other badges), we might quickly know if the tests are globally being failed or not. But hmmm I don't feel strongly. I can take them out in a couple of days if there are no other feedback. How about the logo?

@srowen
Copy link
Member

srowen commented Jan 23, 2019

We have the amplab Jenkins for status, but I suppose this is another place you might notice. Is the AppVeyor test reliable enough to report here? I can see adding the build status to give a little more warning if something seems to be wrong.

The PyPI downloads and commits doesn't seem as useful.

@HyukjinKwon
Copy link
Member Author

Yup, I'm going to take both out, and then gonna take the other out too if there are no more feedback about that. Was wondering how you guys feel about this.

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Jan 23, 2019

BTW, I would also just close this if there's not much feedback about the logo as well. It's not something worth if people are not sure or don't particularly prefer - it's just making something pretty.

@SparkQA
Copy link

SparkQA commented Jan 23, 2019

Test build #101584 has finished for PR 23629 at commit 98fd22a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 23, 2019

Test build #101586 has finished for PR 23629 at commit fe3dc9c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Jan 23, 2019

I think the build ones are definitely useful. The rest I don't know how useful it is.

@SparkQA
Copy link

SparkQA commented Jan 23, 2019

Test build #101593 has finished for PR 23629 at commit 4938c14.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member Author

Let me take out the logo too.

@HyukjinKwon HyukjinKwon changed the title [MINOR] Add Spark logo and badges at README.md [MINOR] Add Jenkins and AppVeyor badges at README.md Jan 24, 2019
Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the build logo

@HyukjinKwon
Copy link
Member Author

Just in case people might want to take the previous change .. take a look at https://github.com/apache/spark/blob/4938c14f4d23880b477d43a6d83ed7e427cb6c7f/README.md and let me know if anyone prefers this.

@felixcheung
Copy link
Member

I kinda like the logo too, why not? :)
I don't feel strongly about it

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Jan 24, 2019

Yes .. :). WDYT @cloud-fan, @gatorsmile, @holdenk? Looks there are no particular opinion about that logo itself so far.

Take a look at this VS the current proposal.

For the former, I referred nodejs and bootstrap

BTW, I expected a bit of forth and back since the preference matters here. It's okay to forth and back - easy to fix and revert in this PR. Feel free to let me know if there's any preference.

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Jan 24, 2019

adding more people to ask preference @BryanCutler, @viirya, @ueshin, @rdblue, @MaxGekk, @mgaido91, @dongjoon-hyun, @hvanhovell who I have talked with time to time in the Spark community (sorry if this cc was too arbitrary).

@SparkQA
Copy link

SparkQA commented Jan 24, 2019

Test build #101607 has finished for PR 23629 at commit cc24b9e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mgaido91
Copy link
Contributor

Thanks for pinging me @HyukjinKwon . Honestly I prefer the current option. It is a README, so the main goal is to provide general information about the project in the clearest possible way. It is not a marketing window where a logo may be more attractive.

@viirya
Copy link
Member

viirya commented Jan 24, 2019

I don't have strong option about this. One idea is currently two icons looks very similar (showing "build running" and "build passing" with different colors). I can't tell too much info from them (e.g., what difference between two).

@HyukjinKwon
Copy link
Member Author

^ if you take a look closely one has AppVeyor logo :D.

@HyukjinKwon
Copy link
Member Author

Right. Let me propose just build badges here for now. Let me merge this one in few days as is then.

@viirya
Copy link
Member

viirya commented Jan 24, 2019

^ if you take a look closely one has AppVeyor logo :D.

I didn't see it in IntelliJ IDEA's markdown visual editor. Saw it when manually opened it in browser. :)

@HyukjinKwon
Copy link
Member Author

Merged to master.

@asfgit asfgit closed this in d97481b Jan 25, 2019
jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
## What changes were proposed in this pull request?

This PR adds Jenkins build and AppVeyor build badges

Take a look at https://github.com/apache/spark/blob/cc24b9e0b35e947e97b47ca9d1b350bb37148b41/README.md

## How was this patch tested?

Manually tested by `grip`.

Closes apache#23629 from HyukjinKwon/minor-badges.

Authored-by: Hyukjin Kwon <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
@HyukjinKwon HyukjinKwon deleted the minor-badges branch March 3, 2020 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants