Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

[PIO-193] Async support for predict method and storage access, blocking code wrapped in blocking construct #495

Open
longliveenduro wants to merge 18 commits into
base: develop
Choose a base branch
from
Open

[PIO-193] Async support for predict method and storage access, blocking code wrapped in blocking construct #495

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
2915d0d
Add Future methods and Scaladoc about ExecutionContext
takezoe Oct 15, 2018
dbea05b
Update Scaladoc
takezoe Oct 15, 2018
998938b
Delegate blocking methods to async methods
takezoe Oct 17, 2018
b0b8a6f
[PIO-193] Async support for predict and storage access, blocking code
Oct 23, 2018
7de2bdf
corrected scalastyle errors
Nov 7, 2018
736144e
explicitly propagating execution context
Nov 7, 2018
183c9a7
switched examples to new predict method and raised docker pio tag ver…
Nov 7, 2018
2ef1e2c
making async support backward compatible
Nov 9, 2018
2d5b1f9
using proper option type for new findByEntityAsync method
Nov 16, 2018
1d7b0c9
added log info about what query gave what recommendation
Nov 16, 2018
7307d18
using a dedicated thread pool for blocking ops
Nov 21, 2018
79e0c96
using a dedicated thread pool for all future ops to HBase
Nov 22, 2018
e6a17fb
using new (non deprecated) versions of hbase classes
Nov 23, 2018
adbe789
closing scanner in any case
Nov 23, 2018
382f177
Revert "closing scanner in any case"
Nov 27, 2018
a06ce23
closing scanner
Nov 27, 2018
dd535a0
Revert "closing scanner"
Nov 27, 2018
fd09c42
cleanup
Nov 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
explicitly propagating execution context
  • Loading branch information
Chris Wewerka committed Nov 7, 2018
commit 736144ec00ee3f85ab82ec090c75318986c1d7b0
2 changes: 1 addition & 1 deletion core/src/main/scala/org/apache/predictionio/controller/LAlgorithm.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ abstract class LAlgorithm[PD, M : ClassTag, Q, P]
}

def predictBase(localBaseModel: Any, q: Q)(implicit ec: ExecutionContext): Future[P] = {
predict(localBaseModel.asInstanceOf[M], q)
predict(localBaseModel.asInstanceOf[M], q)(ec)
}

/** Implement this method to produce a prediction from a query and trained
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/scala/org/apache/predictionio/controller/P2LAlgorithm.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ abstract class P2LAlgorithm[PD, M: ClassTag, Q: ClassTag, P]
}

def predictBase(bm: Any, q: Q)(implicit ec: ExecutionContext): Future[P] =
predict(bm.asInstanceOf[M], q)
predict(bm.asInstanceOf[M], q)(ec)

/** Implement this method to produce a prediction from a query and trained
* model.
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/scala/org/apache/predictionio/controller/PAlgorithm.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ abstract class PAlgorithm[PD, M, Q, P]
throw new NotImplementedError("batchPredict not implemented")

def predictBase(baseModel: Any, query: Q)(implicit ec: ExecutionContext): Future[P] = {
predict(baseModel.asInstanceOf[M], query)
predict(baseModel.asInstanceOf[M], query)(ec)
}

/** Implement this method to produce a prediction from a query and trained
Expand Down