GH-3074: read footer using 1 call readFully(byte[8]) instead of 5 calls #3075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
reviewed
Nov 26, 2024
Member
wgtmac
left a comment
wgtmac
left a comment
There was a problem hiding this comment.
Thanks for the improvement! Please make the CI happy.
Arnaud-Nauwynck
force-pushed
the
master
branch
from
10c2df0 to
4607854
Compare
Member
|
Could you try to rebase it? I think the CI failure is due to based on a problematic commit. |
Contributor
steveloughran
left a comment
steveloughran
left a comment
There was a problem hiding this comment.
LGTM, at least for now.
Parquet 3.0 is going to add some bytes between the metadata length and MAGIC; I don't know if there is anything extra which could be done here.
I think we could start with some test files which already have this new marker and use parsing that as regression testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH-3074: read footer using 1 call readFully(byte[8]) instead of 5 calls
Rationale for this change
performance
What changes are included in this PR?
only method FilePargetReader.readFooter()
Are these changes tested?
Are there any user-facing changes?
no