Skip to content

Conversation

@Fokko
Copy link
Contributor

@Fokko Fokko commented Jun 19, 2024

Make sure you have checked all steps below.

Closes #2920

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines
    from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Style

  • My contribution adheres to the code style guidelines and Spotless passes.
    • To apply the necessary changes, run mvn spotless:apply -Pvector-plugins

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@nastra
Copy link
Contributor

nastra commented Jul 13, 2024

spotless 2.31.0 changed the minimum JDK from 8 to 11: https://github.com/diffplug/spotless/blob/main/plugin-maven/CHANGES.md#changed-13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump Spotless to 2.43.0

2 participants