KAFKA-19987: Add metrics from KIP-1216 to ops.html #21130
Conversation
This commit adds the new thread-level rebalance listener callback metrics from KIP-1216 to the Streams Monitoring section in ops.html: - tasks-revoked-latency-avg and tasks-revoked-latency-max - tasks-assigned-latency-avg and tasks-assigned-latency-max - tasks-lost-latency-avg and tasks-lost-latency-max All metrics are at the INFO recording level and measure time in milliseconds.
There was a problem hiding this comment.
Pull request overview
This PR adds six new thread-level rebalance listener callback metrics from KIP-1216 to the Kafka Streams monitoring documentation in ops.html.
Key Changes:
- Added documentation for tasks-revoked-latency-avg and tasks-revoked-latency-max metrics
- Added documentation for tasks-assigned-latency-avg and tasks-assigned-latency-max metrics
- Added documentation for tasks-lost-latency-avg and tasks-lost-latency-max metrics
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| </tr> | ||
| <tr> | ||
| <td>tasks-lost-latency-max</td> | ||
| <td>The maximum time in ms taken for tasks-lost rebalance listener callback.</td> |
There was a problem hiding this comment.
The description should use "execution time" instead of "time" to be consistent with other thread-level latency metrics in this section (e.g., commit-latency-max, poll-latency-max, process-latency-max). Additionally, add a comma after "ms" to match the formatting pattern used by other thread metrics.
| <td>The maximum time in ms taken for tasks-lost rebalance listener callback.</td> | |
| <td>The maximum execution time in ms, taken for tasks-lost rebalance listener callback.</td> |
| </tr> | ||
| <tr> | ||
| <td>tasks-revoked-latency-avg</td> | ||
| <td>The average time in ms taken for tasks-revoked rebalance listener callback.</td> |
There was a problem hiding this comment.
The description should use "execution time" instead of "time" to be consistent with other thread-level latency metrics in this section (e.g., commit-latency-avg, poll-latency-avg, process-latency-avg). Additionally, add a comma after "ms" to match the formatting pattern used by other thread metrics.
| <td>The average time in ms taken for tasks-revoked rebalance listener callback.</td> | |
| <td>The average execution time in ms, taken for tasks-revoked rebalance listener callback.</td> |
| </tr> | ||
| <tr> | ||
| <td>tasks-revoked-latency-max</td> | ||
| <td>The maximum time in ms taken for tasks-revoked rebalance listener callback.</td> |
There was a problem hiding this comment.
The description should use "execution time" instead of "time" to be consistent with other thread-level latency metrics in this section (e.g., commit-latency-max, poll-latency-max, process-latency-max). Additionally, add a comma after "ms" to match the formatting pattern used by other thread metrics.
| <td>The maximum time in ms taken for tasks-revoked rebalance listener callback.</td> | |
| <td>The maximum execution time in ms, taken for tasks-revoked rebalance listener callback.</td> |
| </tr> | ||
| <tr> | ||
| <td>tasks-assigned-latency-avg</td> | ||
| <td>The average time in ms taken for tasks-assigned rebalance listener callback.</td> |
There was a problem hiding this comment.
The description should use "execution time" instead of "time" to be consistent with other thread-level latency metrics in this section (e.g., commit-latency-avg, poll-latency-avg, process-latency-avg). Additionally, add a comma after "ms" to match the formatting pattern used by other thread metrics.
| <td>The average time in ms taken for tasks-assigned rebalance listener callback.</td> | |
| <td>The average execution time in ms, taken for tasks-assigned rebalance listener callback.</td> |
| </tr> | ||
| <tr> | ||
| <td>tasks-assigned-latency-max</td> | ||
| <td>The maximum time in ms taken for tasks-assigned rebalance listener callback.</td> |
There was a problem hiding this comment.
The description should use "execution time" instead of "time" to be consistent with other thread-level latency metrics in this section (e.g., commit-latency-max, poll-latency-max, process-latency-max). Additionally, add a comma after "ms" to match the formatting pattern used by other thread metrics.
| <td>The maximum time in ms taken for tasks-assigned rebalance listener callback.</td> | |
| <td>The maximum execution time in ms, taken for tasks-assigned rebalance listener callback.</td> |
| </tr> | ||
| <tr> | ||
| <td>tasks-lost-latency-avg</td> | ||
| <td>The average time in ms taken for tasks-lost rebalance listener callback.</td> |
There was a problem hiding this comment.
The description should use "execution time" instead of "time" to be consistent with other thread-level latency metrics in this section (e.g., commit-latency-avg, poll-latency-avg, process-latency-avg). Additionally, add a comma after "ms" to match the formatting pattern used by other thread metrics.
| <td>The average time in ms taken for tasks-lost rebalance listener callback.</td> | |
| <td>The average execution time in ms, taken for tasks-lost rebalance listener callback.</td> |
|
picked to 4.2 |
This commit adds the new thread-level rebalance listener callback metrics from KIP-1216 to the Streams Monitoring section in ops.html: - tasks-revoked-latency-avg and tasks-revoked-latency-max - tasks-assigned-latency-avg and tasks-assigned-latency-max - tasks-lost-latency-avg and tasks-lost-latency-max All metrics are at the INFO recording level and measure time in milliseconds. Reviewers: Matthias J. Sax <[email protected]>
This commit adds the new thread-level rebalance listener callback metrics from KIP-1216 to the Streams Monitoring section in ops.html: - tasks-revoked-latency-avg and tasks-revoked-latency-max - tasks-assigned-latency-avg and tasks-assigned-latency-max - tasks-lost-latency-avg and tasks-lost-latency-max All metrics are at the INFO recording level and measure time in milliseconds. Reviewers: Matthias J. Sax <[email protected]>
2 participants
This commit adds the new thread-level rebalance listener callback
metrics from KIP-1216 to the Streams Monitoring section in ops.html:
All metrics are at the INFO recording level and measure time in
milliseconds.
Reviewers: Matthias J. Sax [email protected]