Skip to content

KAFKA-19920 : Metadata | Fixed order of arguments of assertEquals in unit tests #21113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
samarth-ksolves wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

KAFKA-19920 : Metadata | Fixed order of arguments of assertEquals in unit tests #21113

samarth-ksolves wants to merge 1 commit into from

Conversation

@samarth-ksolves
Copy link
Contributor

@samarth-ksolves samarth-ksolves commented Dec 9, 2025

In this PR, we corrected the argument order in assertEquals within the
metadata package.

@github-actions github-actions bot added triage PRs from the community tests Test fixes (including flaky tests) kraft small Small PRs labels Dec 9, 2025
sjhajharia
sjhajharia approved these changes Dec 10, 2025
View reviewed changes
Copy link
Collaborator

@sjhajharia sjhajharia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM!

@github-actions github-actions bot removed the triage PRs from the community label Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sjhajharia sjhajharia sjhajharia approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ci-approved kraft small Small PRs tests Test fixes (including flaky tests)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samarth-ksolves @sjhajharia