MINOR: Introduce TopicRegexResolver and Move Regex Resolution Logic Out of GroupMetadataManager #21103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
dajac
reviewed
Dec 10, 2025
...tor/src/main/java/org/apache/kafka/coordinator/group/modern/consumer/TopicRegexResolver.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/apache/kafka/coordinator/group/modern/consumer/TopicRegexResolverTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/apache/kafka/coordinator/group/modern/consumer/TopicRegexResolverTest.java
Outdated
Show resolved
Hide resolved
shashankhs11
pushed a commit
to shashankhs11/kafka
that referenced
this pull request
Dec 15, 2025
…ut of GroupMetadataManager (apache#21103) This patch introduces a dedicated `TopicRegexResolver` component responsible for resolving regex-based topic subscriptions. The logic was previously embedded within `GroupMetadataManager`, coupling group metadata operations with topic pattern matching. By extracting this logic into a dedicated resolver, we improve modularity and make the topic resolution behavior easier to evolve and test independently. `GroupMetadataManager` is updated to delegate regex resolution to the new component, without altering existing semantics. This is a non-functional refactor intended to improve code clarity and maintainability. Reviewers: David Jacot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces a dedicated
TopicRegexResolvercomponentresponsible for resolving regex-based topic subscriptions. The logic was
previously embedded within
GroupMetadataManager, coupling groupmetadata operations with topic pattern matching.
By extracting this logic into a dedicated resolver, we improve
modularity and make the topic resolution behavior easier to evolve and
test independently.
GroupMetadataManageris updated to delegate regexresolution to the new component, without altering existing semantics.
This is a non-functional refactor intended to improve code clarity and
maintainability.
Reviewers: David Jacot [email protected]