Skip to content

KAFKA-12617: Convert MetadataRequestTest to use ClusterTest #21101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jack2012aa wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

KAFKA-12617: Convert MetadataRequestTest to use ClusterTest #21101

jack2012aa wants to merge 5 commits into from

Conversation

@jack2012aa
Copy link
Contributor

@jack2012aa jack2012aa commented Dec 7, 2025

Description

Changed MetadataRequestTest to use ClusterTest

Changes

Added ClusterInstance#createTopicWithAssignment to align with KafkaServerTestHarness#createTopicWithAssignment

Helper functions inherited from base classes were rewritten in AbstractMetadataRequestTest

Issue

testIsrAfterBrokerShutDownAndJoinsBack fails because of thread leak:

org.opentest4j.AssertionFailedError: Thread leak detected: JMX server connection timeout 28 ==> 
Expected :true
Actual   :false

testAliveBrokersWithNoTopics would also fail if the last checkMetadata is removed.

@jack2012aa
Temp
5801d01
@jack2012aa
Temp
81cae24
@jack2012aa
Change to ClusterTest
23fa4a5
@jack2012aa
Merge branch 'trunk' into KAFKA-12617
ce7f0ed 
# Conflicts:
#	core/src/test/scala/unit/kafka/server/MetadataRequestTest.scala
@github-actions github-actions bot added triage PRs from the community core Kafka Broker tests Test fixes (including flaky tests) labels Dec 7, 2025
@jack2012aa jack2012aa marked this pull request as ready for review December 8, 2025 18:56
chia7712
chia7712 reviewed Dec 10, 2025
View reviewed changes
core/src/test/scala/unit/kafka/server/AbstractMetadataRequestTest.scala
import scala.jdk.CollectionConverters.{CollectionHasAsScala, MapHasAsJava, SeqHasAsJava}

override def brokerPropertyOverrides(properties: Properties): Unit = {
abstract class AbstractMetadataRequestTest(cluster: ClusterInstance) {
Copy link
Member

@chia7712 chia7712 Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since AbstractMetadataRequestTest is only used by MetadataRequestTest. Perhaps we could merge the two files together?

chia7712
chia7712 reviewed Dec 10, 2025
View reviewed changes
core/src/test/scala/unit/kafka/server/MetadataRequestTest.scala
new ClusterConfigProperty(id = 2, key = "broker.rack", value = "rack/2")
)
)
class MetadataRequestTest(cluster: ClusterInstance) extends AbstractMetadataRequestTest(cluster) {
Copy link
Member

@chia7712 chia7712 Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rewrite it by java. Also, please move it to server module

@github-actions github-actions bot removed the triage PRs from the community label Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chia7712 chia7712 chia7712 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ci-approved core Kafka Broker tests Test fixes (including flaky tests)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jack2012aa @chia7712