[BP-2.0][FLINK-38486] Harden shutdown of system UDFs #27337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a resource is lazily created in open, we can only close after checking for null. Otherwise a failure during initialization will trigger secondary failures.
Collaborator
Contributor
Author
|
@flinkbot run azure |
davidradl
reviewed
Dec 15, 2025
| spanProcessor.close(); | ||
| spanExporter.flush(); | ||
| spanExporter.close(); | ||
| if (spanProcessor != null) { |
Contributor
There was a problem hiding this comment.
I know this is a back port, I am wondering if we get an exception processing the spanProcessor shouldn't we still try to clean up spanExporter if we have one. i.e. put the spanExporter code in a finally.
Contributor
Author
There was a problem hiding this comment.
According to the code, spanProcessor and spanExporter must be either null or not null both.
gustavodemorais
approved these changes
Dec 15, 2025
Contributor
|
@flinkbot run azure |
Contributor
Author
|
Test failure seems to be unrelated (failed to download cri-dockerd), merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #27089 to release-2.0