[FLINK-38797][python] Fixed PyFlink issue CsvSchemaBuilder.set_null_value missing return self #27331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Contributor
Author
|
Prior commit ran into flake8 check so renamed the test method Seeing if I can trigger a re-run of CI |
davidradl
reviewed
Dec 12, 2025
| schema = CsvSchema.builder() \ | ||
| .add_string_column('string') \ | ||
| .add_number_column('number') \ | ||
| .set_null_value('') \ |
Contributor
There was a problem hiding this comment.
Looks good. Some testing suggestions:
I would test a test with .set_null_value(), set the default? If so we should test that
I also suggest a test specifying that a non default literal for null works.
Contributor
There was a problem hiding this comment.
A null_value must be specified if .set_null_value is called. There is no default value.
github-actions
bot
added
the
community-reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Currently,
CsvSchemaBuilder.set_null_valuedoesn'treturn selfwhich breaks the builder design pattern which in turn makes the method unusable without workaround to retrieve the private_j_schema_builderobject to callsetNullValuedirectly. If left as-is, the current usage of the method with respect to the builder design pattern returns something like:Brief change log
return selfto the end of theCsvSchemaBuilder.set_null_valuemethodVerifying this change
This change added tests and can be verified as follows:
test_csv_default_null_valueand helper methods which test empty string,''is treated as null (i.e.,Nonein Python)Does this pull request potentially affect one of the following parts:
@Public(Evolving): noCsvSchemaBuilderwon't work properly as-is so this PR fixes itDocumentation