Correct several misspellings #4677
Conversation
huyuanfeng2018
commented
Dec 11, 2025
huyuanfeng2018
commented
- Fix "neccessary" to "necessary" in cassandra.yaml
- Fix "identifer" to "identifier" in SqlSimpleParser.java
- Fix "teh" to "the" in Db2SqlDialect.java
- Fix "identifers" to "identifiers" in SqlBuilder.java
- Fix "begining" to "beginning" in cast-with-format.iq
- Fix "looses" to "loses" in history.md
mihaibudiu
left a comment
mihaibudiu
left a comment
There was a problem hiding this comment.
I am not sure that the build likes commit messages starting with "fix"
Maybe "Correct several misspellings?"
| // If one operand is a date, the other labeled duration of YEARS, MONTHS, or DAYS. | ||
| // If one operand is a time, the other must be labeled duration of HOURS, MINUTES, or SECONDS. | ||
| // If one operand is a timestamp, the other operand can be any of teh duration. | ||
| // If one operand is a timestamp, the other operand can be any of the duration. |
There was a problem hiding this comment.
I would remove "of the"
There was a problem hiding this comment.
Thank you for your contribution. Would you be willing to modify this section and your commit message?
There was a problem hiding this comment.
Thanks for the ping , done.
There was a problem hiding this comment.
I may not have explained clearly enough. It needs to be revised according to Mihai’s comments, and the commits should be squashed into one. The commit message should match the PR title, as this is a commit convention in Calcite.
There was a problem hiding this comment.
I may not have explained clearly enough. It needs to be revised according to Mihai’s comments, and the commits should be squashed into one. The commit message should match the PR title, as this is a commit convention in Calcite.
sry, this is my first time contributing on Calcite, and I have compressed and resubmitted , PTAL~
There was a problem hiding this comment.
No need to feel sorry. This is a first good contribution.
huyuanfeng2018
force-pushed
the
fix-typo
branch
from
6080b1c to
d870cc9
Compare
|
|
Thanks for contribution @huyuanfeng2018 and review @mihaibudiu |
3 participants
