Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-2974: [Python] Replace usages of "source activate" with "conda activate" in CI scripts #2507

Closed
wants to merge 1 commit into from
Closed

ARROW-2974: [Python] Replace usages of "source activate" with "conda activate" in CI scripts #2507

wants to merge 1 commit into from

Conversation

kszucs
Copy link
Member

@kszucs kszucs commented Sep 2, 2018 •
edited by wesm
Loading

Also includes temporary pin to meson 0.47.1 in the glib build per ARROW-3186

@kszucs kszucs changed the title ARROW-2974: [Python] Replace usages of "source activate" with "conda activate" in CI scriptsARROW-2974: [Python] Replace usages of "source activate" with "conda activate" in CI scripts ARROW-2974: [Python] Replace usages of "source activate" with "conda activate" in CI scripts Sep 2, 2018
@wesm
Copy link
Member

wesm commented Sep 2, 2018

If you do this, then you need to undo the path modification in

https://github.com/apache/arrow/blob/master/ci/travis_env_common.sh#L23

and replace it with something like

source $MINICONDA/etc/profile.d/conda.sh

@kszucs
Copy link
Member Author

kszucs commented Sep 2, 2018

Well, I forgot that. Thanks!

@wesm wesm force-pushed the conda_activate branch 2 times, most recently from 3e99fb1 to 8c6a000 Compare September 5, 2018 15:56
@wesm
Copy link
Member

wesm commented Sep 7, 2018

This contains a temporary fix for ARROW-3186, i.e. the mesonbuild bug we've been seeing

@wesm wesm mentioned this pull request Sep 7, 2018
Merged
wesm
wesm approved these changes Sep 7, 2018
View reviewed changes
Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Merging this with the temporary fix for ARROW-3186 until that can be investigated separately

@wesm wesm closed this in c1f528c Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesm wesm wesm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kszucs @wesm