Refactor DAG.create_dagrun() arguments #45370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
uranusjr
force-pushed
the
create-dagrun-refactor
branch
6 times, most recently
from
34a7033 to
5392e2b
Compare
uranusjr
requested review from
potiuk,
ashb,
jedcunningham,
mobuchowski,
eladkal,
ryanahamilton,
bbovenzi,
pierrejeambrun,
jscheffl,
ephraimbuddy and
XD-DENG
as code owners
uranusjr
force-pushed
the
create-dagrun-refactor
branch
from
296f247 to
09e98d2
Compare
Lee-W
reviewed
Jan 15, 2025
Lee-W
approved these changes
Jan 15, 2025
ephraimbuddy
approved these changes
Jan 15, 2025
This aims to make the interface more straightforward, removing auto inference logic from the function. Most importantly, it is now entirely the caller site's responsibility to provide valid run_id and run_type values, instead of the function automatically inferring one from the other under certain conditions. The main goal is to make changes simpler when we make logical date an optional (nullable) value. run_id generation is currently very heavily based on the logical date, and will need to be changed a bit when logical date is None. Removing logic should help us change the run_id generation logic easier.
We can have dag_version and run_type defaults since this is just for tests and the actual values aren't that important most of the times.
uranusjr
force-pushed
the
create-dagrun-refactor
branch
from
acf0a03 to
0556951
Compare
|
re: Breaking change, I don’t think we need to since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to make the interface more straightforward, removing auto inference logic from the function. Most importantly, it is now entirely the caller site's responsibility to provide valid run_id and run_type values, instead of the function automatically inferring one from the other under certain conditions.
The main goal is to make changes simpler when we make logical date an optional (nullable) value. run_id generation is currently very heavily based on the logical date, and will need to be changed a bit when logical date is None. Removing logic should help us change the run_id generation logic easier.
p.s. not yet ready, many tests should fail.Finally ready; this took way much more than I thought.