Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update taskinstance clear endpoint to support mapped tasks #45349

Merged
merged 20 commits into from
Jan 27, 2025
Merged

Update taskinstance clear endpoint to support mapped tasks #45349

merged 20 commits into from
Jan 27, 2025

Conversation

vatsrahul1001
Copy link
Collaborator

@vatsrahul1001 vatsrahul1001 commented Jan 2, 2025 •
edited
Loading

closes: #44867

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Jan 2, 2025
@vatsrahul1001 vatsrahul1001 marked this pull request as draft January 2, 2025 12:59
@vatsrahul1001 vatsrahul1001 added the legacy api Whether legacy API changes should be allowed in PR label Jan 2, 2025
@jscheffl jscheffl added the legacy ui Whether legacy UI change should be allowed in PR label Jan 2, 2025
@jscheffl
Copy link
Contributor

jscheffl commented Jan 2, 2025

I you plan to update the API, this one (connexion) is the legacy one which will be dropped in Airflow 3. Can you please also change the fast_api which will be the future/Airflow 3 API backend?

As this change is on connexion API, is this to be back-ported to Airflow 2.10 as well? Then it should be classified as a bug, as we actually do not plan to have new features on Airflow 2.10

pierrejeambrun
pierrejeambrun reviewed Jan 6, 2025
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I you plan to update the API, this one (connexion) is the legacy one which will be dropped in Airflow 3. Can you please also change the fast_api which will be the future/Airflow 3 API backend?

+1

As this change is on connexion API, is this to be back-ported to Airflow 2.10 as well? Then it should be classified as a bug, as we actually do not plan to have new features on Airflow 2.10

I think this one is really an improvement/feature. I would be for simply not releasing this in 2.x at all. Features are for 3.0, and just do the change in the fastapi API.

@vatsrahul1001
Copy link
Collaborator Author

+1 @pierrejeambrun @jscheffl . I agree as its a new feature/Improvement this should only go to FastAPI. I will update this for only FastAPI.

I think this one is really an improvement/feature. I would be for simply not releasing this in 2.x at all. Features are for 3.0, and just do the change in the fastapi API.

@vatsrahul1001
Merge branch 'main' of github.com:astronomer/airflow into update-task…
c13a5e3 
…instance-clear-endpoint-to-support-mapped-tasks
@vatsrahul1001
Merge branch 'main' of github.com:astronomer/airflow into update-task…
efa3a9d 
…instance-clear-endpoint-to-support-mapped-tasks
@vatsrahul1001
update-taskinstance-clear-endpoint-to-support-mapped-tasks
e7bcb0d
@vatsrahul1001
Merge branch 'update-taskinstance-clear-endpoint-to-support-mapped-ta…
83a6d2b 
…sks' of github.com:astronomer/airflow into update-taskinstance-clear-endpoint-to-support-mapped-tasks
@vatsrahul1001
adding tests
95b853a
@vatsrahul1001 vatsrahul1001 marked this pull request as ready for review January 7, 2025 10:41
pierrejeambrun
pierrejeambrun reviewed Jan 20, 2025
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks. A few things to update before we can merge.

pierrejeambrun
pierrejeambrun reviewed Jan 21, 2025
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Looks good. A few more suggestions.

pierrejeambrun
pierrejeambrun approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, minor nit, needs rebase.

@pierrejeambrun pierrejeambrun merged commit 2b46b8f into apache:main Jan 27, 2025
45 checks passed
@pierrejeambrun pierrejeambrun deleted the update-taskinstance-clear-endpoint-to-support-mapped-tasks branch January 27, 2025 11:35
josix pushed a commit to josix/airflow that referenced this pull request Jan 27, 2025
@vatsrahul1001 @josix
Update taskinstance clear endpoint to support mapped tasks (apache#45349
6753fdd 
)

* support mapped task in taskinstance clear

* update-taskinstance-clear-endpoint-to-support-mapped-tasks

* adding tests

* adding tests

* fix test

* resolving conflicts

* update typing and format of request

* add new tests + fix useClearTaskInstances.ts

* add comment
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
@vatsrahul1001 @got686-yandex
Update taskinstance clear endpoint to support mapped tasks (apache#45349
5279639 
)

* support mapped task in taskinstance clear

* update-taskinstance-clear-endpoint-to-support-mapped-tasks

* adding tests

* adding tests

* fix test

* resolving conflicts

* update typing and format of request

* add new tests + fix useClearTaskInstances.ts

* add comment
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Jan 30, 2025
@vatsrahul1001 @ambika-garg
Update taskinstance clear endpoint to support mapped tasks (apache#45349
1aa9407 
)

* support mapped task in taskinstance clear

* update-taskinstance-clear-endpoint-to-support-mapped-tasks

* adding tests

* adding tests

* fix test

* resolving conflicts

* update typing and format of request

* add new tests + fix useClearTaskInstances.ts

* add comment
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
@vatsrahul1001 @niklasr22
Update taskinstance clear endpoint to support mapped tasks (apache#45349
d5b840e 
)

* support mapped task in taskinstance clear

* update-taskinstance-clear-endpoint-to-support-mapped-tasks

* adding tests

* adding tests

* fix test

* resolving conflicts

* update typing and format of request

* add new tests + fix useClearTaskInstances.ts

* add comment
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
@vatsrahul1001 @ambika-garg
Update taskinstance clear endpoint to support mapped tasks (apache#45349
d196911 
)

* support mapped task in taskinstance clear

* update-taskinstance-clear-endpoint-to-support-mapped-tasks

* adding tests

* adding tests

* fix test

* resolving conflicts

* update typing and format of request

* add new tests + fix useClearTaskInstances.ts

* add comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierrejeambrun pierrejeambrun pierrejeambrun approved these changes

@eladkal eladkal eladkal approved these changes

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton

@ashb ashb Awaiting requested review from ashb

@bbovenzi bbovenzi Awaiting requested review from bbovenzi

@jscheffl jscheffl Awaiting requested review from jscheffl

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy

Assignees
No one assigned
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues legacy api Whether legacy API changes should be allowed in PR legacy ui Whether legacy UI change should be allowed in PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update taskinstance clear endpoint to support mapped tasks
4 participants
@vatsrahul1001 @jscheffl @pierrejeambrun @eladkal