Skip to content

Remove Automatic Display Answer global setting #17464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
david-allison merged 1 commit into from
Dec 6, 2024
Merged

Remove Automatic Display Answer global setting #17464

david-allison merged 1 commit into from
Dec 6, 2024

Conversation

@MorenoTropical
Copy link
Contributor

@MorenoTropical MorenoTropical commented Nov 19, 2024

People get confused when they enable Auto Advance but it doesn't work. The preference had an use when Anki didn't have Auto advance, but now it doesn't have a purpose because everything can be configured from deck options

Example: https://forums.ankiweb.net/t/auto-advance-in-deck-options/51898

Fixes

Approach

Removed the global setting

How Has This Been Tested?

Tested if auto advance still works

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2024

Important

Maintainers: This PR contains Strings changes

  1. Sync Translations before merging this PR and wait for the action to complete
  2. Review and merge the auto-generated PR in order to sync all user-submitted translations
  3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

@MorenoTropical MorenoTropical force-pushed the autodisplay branch 3 times, most recently from 4f81ac5 to fb94679 Compare November 19, 2024 15:43
@MorenoTropical
Remove Automatic Display Answer global setting
fb94679 
People get confused when they enable Auto Advance but it doesn't work. The preference had an use when Anki didn't have Auto advance, but now it doesn't have a purpose.

Example: https://forums.ankiweb.net/t/auto-advance-in-deck-options/51898
@brishtibheja
Copy link

brishtibheja commented Nov 19, 2024

I appreciate this as this has confused many users before (including me). But perhaps, some people find use in this if they use Auto Advance in desktop but not on their phones? The desktop also has an option for turning on auto advance other than the deck options one.

@MorenoTropical
Copy link
Contributor Author

MorenoTropical commented Nov 19, 2024

The desktop also has an option for turning on auto advance other than the deck options one.

It doesn't.

@brishtibheja
Copy link

brishtibheja commented Nov 19, 2024 •
edited
Loading

I thought you needed to select Auto Advance as documented here: https://docs.ankiweb.net/deck-options.html#auto-advance

We updated that topic a few months ago, so shouldn't get outdated. But I could be wrong about desktop.

@MorenoTropical
Copy link
Contributor Author

MorenoTropical commented Nov 20, 2024 •
edited
Loading

I thought you needed to select Auto Advance

That isn't a setting. It's equivalent to the Toggle auto advance feature in AnkiDroid's reviewer. Haven't you checked it before stating it?

There isn't a global setting.

BrayanDSO
BrayanDSO approved these changes Nov 23, 2024
View reviewed changes
Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For ecossystem compatibility, I'll aprove this. The new reviewer already ignores that setting. Since we have the Toggle auto advance feature in the reviewer, which is more pratical than going to the settings, removing it shouldn't create a big problem.

@BrayanDSO BrayanDSO added the Needs Second Approval Has one approval, one more approval to merge label Nov 23, 2024
mikehardy
mikehardy requested changes Dec 4, 2024
View reviewed changes
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to remove for ecosystem compat

one question on res/values/constants.xml change

@mikehardy mikehardy added Needs Author Reply Waiting for a reply from the original author Anki Ecosystem Compatibility labels Dec 4, 2024
mikehardy
mikehardy approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just needs the 3-step strings + merge this + strings dance

@mikehardy mikehardy added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Author Reply Waiting for a reply from the original author Anki Ecosystem Compatibility Needs Second Approval Has one approval, one more approval to merge labels Dec 5, 2024
@david-allison
Copy link
Member

david-allison commented Dec 5, 2024

@david-allison david-allison added this pull request to the merge queue Dec 6, 2024
Merged via the queue into ankidroid:main with commit f33810d Dec 6, 2024
9 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR.

Read more about updating strings on the wiki,

@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Dec 6, 2024
@github-actions github-actions bot added this to the 2.21 release milestone Dec 6, 2024
@david-allison david-allison mentioned this pull request Dec 6, 2024
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Hi there @MorenoTropical! This is the OpenCollective Notice for PRs merged from 2024-12-01 through 2024-12-31

If you are interested in compensation for this work, the process with details is here:

https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

Important

PLEASE NOTE: The process was updated in August 2024. Re-read the Payment Process page if you have not already.

We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!

@david-allison david-allison mentioned this pull request Jan 4, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikehardy mikehardy mikehardy approved these changes

@BrayanDSO BrayanDSO BrayanDSO approved these changes

Assignees

No one assigned

Labels

Strings

Projects

None yet

Milestone

2.21 release

Development

Successfully merging this pull request may close these issues.

Remove Automatic Display Answer global setting

5 participants

@MorenoTropical @brishtibheja @david-allison @mikehardy @BrayanDSO