-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix: multimedia options opening more than once #17455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: multimedia options opening more than once #17455
Conversation
lukstbit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, this seems to fix the linked issue at least
Note: there's a bug if MultimediaImageFragments's activity gets killed during the user choosing an image for example. If this happens the user will be stuck in the choosing screen.
How to reproduce: enable "Don't keep activities" -> NoteEditor -> Attach Icon -> go and select "Open gallery" -> try to select an image -> stuck in the image chooser screen
It would be nice to fix this issue in this PR(it's the same opening multiple times but for a different reason) but I would also accept merging this and creating an issue with the bug above.
|
Handled that |
david-allison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@criticalAY Is a test here feasible?
If not, let's get this in
|
We can get it in, I created test in a separate PR |
|
🚀🚀 |
Purpose / Description
Root Cause of the issue was:
Fixes
Approach
Keep track of the job
How Has This Been Tested?
Tested on Google emulator API35
Checklist
Please, go through these checks before submitting the PR.