refactor: int constants => enum #17435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arthur-Milchior
force-pushed
the
some_enum
branch
from
6b5acb0 to
33a3ae4
Compare
david-allison
requested changes
Nov 13, 2024
Member
There was a problem hiding this comment.
Note: both of these classes are planned to be deleted.
Signal is fine. Good change
I don't like Caller from an architecture POV, but I don't feel strongly here.
I do want to stop using implicit enum ordinals, and that's what I'll request changes on: that makes the order of the enums a source of bugs.
david-allison
added
the
Needs Author Reply
Arthur-Milchior
force-pushed
the
some_enum
branch
from
33a3ae4 to
0fc1957
Compare
This comment was marked as outdated.
This comment was marked as outdated.
david-allison
added
the
cleanup
david-allison
approved these changes
Nov 29, 2024
david-allison
added
Needs Second Approval
Arthur-Milchior
force-pushed
the
some_enum
branch
from
0fc1957 to
649dc83
Compare
mikehardy
approved these changes
Dec 4, 2024
Member
mikehardy
left a comment
mikehardy
left a comment
There was a problem hiding this comment.
fine by me, assuming conflict is cleaned up merge at will IMHO
mikehardy
added
Pending Merge
Allows removal of an 'else' and improve typing.
Improve typing
david-allison
force-pushed
the
some_enum
branch
from
649dc83 to
9d21300
Compare
github-actions
bot
removed
the
Pending Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those commits add some enum for the sake of code clarity