refactor(core): use ApplicationRef.whenStable instead of a custom util function
#58834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
added
action: review
angular-robot
bot
added
area: core
…til function This commit removes a custom `whenStable` util in favor of standard `ApplicationRef.whenStable` API. There is also an important different between the custom `whenStable` function and `ApplicationRef.whenStable` implementation: the `whenStable` was caching the "stable" promise on per-ApplicationRef basis, which resulted in unexpected behavior with zoneless, when some code ended up getting a stale resolved promise, when an application was not stable yet, this causing order of operations issues. This commit also has an extra test that covers that case.
AndrewKushnir
force-pushed
the
app_ref_zoneless_ssr
branch
from
573c149 to
7569490
Compare
angular-robot
bot
added
area: core
Contributor
|
@AndrewKushnir @alan-agius4 I removed the same on angular cli based on the comments angular/angular-cli#28944 |
AndrewKushnir
added
action: presubmit
Contributor
Author
Contributor
Author
@sheikalthaf thanks for your help! |
AndrewKushnir
added
action: merge
thePunderWoman
pushed a commit
that referenced
this pull request
Nov 25, 2024
…til function (#58834) This commit removes a custom `whenStable` util in favor of standard `ApplicationRef.whenStable` API. There is also an important different between the custom `whenStable` function and `ApplicationRef.whenStable` implementation: the `whenStable` was caching the "stable" promise on per-ApplicationRef basis, which resulted in unexpected behavior with zoneless, when some code ended up getting a stale resolved promise, when an application was not stable yet, this causing order of operations issues. This commit also has an extra test that covers that case. PR Close #58834
Contributor
|
This PR was merged into the repository by commit 7f6f5f9. The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes a custom
whenStableutil in favor of standardApplicationRef.whenStableAPI.There is also an important difference between the custom
whenStablefunction andApplicationRef.whenStableimplementation: thewhenStablewas caching the "stable" promise on per-ApplicationRef basis, which resulted in unexpected behavior with zoneless, when some code ended up getting a stale resolved promise, when an application was not stable yet, this causing order of operations issues. This commit also has an extra test that covers that case.Does this PR introduce a breaking change?