refactor(router): remove unused default error handler function #58819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Could you please reword your commit, this isn't a fix in a functionnal sense but a refactoring. Thank you. |
JeanMeche
added
the
action: cleanup
with v19 the `defaultErrorHandler` has become unused, so could be removed
JelleBruisten
force-pushed
the
JelleBruisten-patch-1
branch
from
ed59e3e to
60c5f46
Compare
Contributor
Author
|
@JeanMeche I've updated the commit message |
AndrewKushnir
added
target: patch
AndrewKushnir
changed the title
AndrewKushnir
approved these changes
Nov 26, 2024
Contributor
AndrewKushnir
left a comment
AndrewKushnir
left a comment
There was a problem hiding this comment.
@JelleBruisten thanks for the refactoring!
Contributor
AndrewKushnir
added
action: merge
thePunderWoman
pushed a commit
that referenced
this pull request
Nov 26, 2024
with v19 the `defaultErrorHandler` has become unused, so could be removed PR Close #58819
Contributor
|
This PR was merged into the repository by commit 61ae17a. The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with v19 the
defaultErrorHandlerhas become unused, so could be removedPR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Unused defaultErrorHandler function
What is the new behavior?
old unused function has been removed
Does this PR introduce a breaking change?
Other information