Skip to content

Conversation

@wartab
Copy link
Contributor

@wartab wartab commented Nov 21, 2024

The previous warning contained a typo and also somewhat implied that allowSignalWrites did something. However, setting allowSignalWrites to false has no impact at all in Angular 19.

Closes #58790

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #58790

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Component({
  selector: 'app-root',
  template: "{{someSignal()}}",
  standalone: true,
})
export class AppComponent {

  someSignal = signal("test");

  constructor() {
    effect(() => {
      this.someSignal.set("Hello World");
    }, {allowSignalWrites: false});
  }
}

This will show "Hello World", so the new warning seems more appropriate.

@pullapprove pullapprove bot requested a review from crisbeto November 21, 2024 11:25
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Nov 21, 2024
@ngbot ngbot bot added this to the Backlog milestone Nov 21, 2024
…warning more accurate

The previous warning contained a typo and also somewhat implied that allowSignalWrites did something. However, setting allowSignalWrites to false has no impact at all in Angular 19.

Closes angular#58790
@wartab wartab force-pushed the allow-signal-writes branch from 0720e2c to f5e2bd5 Compare November 21, 2024 12:18
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Nov 21, 2024
@ngbot ngbot bot modified the milestone: Backlog Nov 21, 2024
@JeanMeche JeanMeche added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 24, 2024
@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 27, 2024
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 4e4bbb0.

The changes were merged into the following branches: main, 19.0.x

pkozlowski-opensource pushed a commit that referenced this pull request Nov 27, 2024
…warning more accurate (#58792)

The previous warning contained a typo and also somewhat implied that allowSignalWrites did something. However, setting allowSignalWrites to false has no impact at all in Angular 19.

Closes #58790

PR Close #58792
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

allowSignalWrites: true warning message typo

4 participants