Skip to content

docs: move commit message guidelies to a separate file #58786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kirjs wants to merge 4 commits into from
Closed

docs: move commit message guidelies to a separate file #58786

kirjs wants to merge 4 commits into from
+176 −157

Conversation

@kirjs
Copy link
Contributor

@kirjs kirjs commented Nov 20, 2024 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from devversion November 20, 2024 21:50
@angular-robot angular-robot bot added the area: docs Related to the documentation label Nov 20, 2024
@ngbot ngbot bot added this to the Backlog milestone Nov 20, 2024
jelbourn
jelbourn reviewed Nov 20, 2024
View reviewed changes
@devversion devversion removed their request for review November 21, 2024 12:26
@pullapprove pullapprove bot requested a review from devversion November 21, 2024 12:26
devversion
devversion approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for .github/PULL_REQUEST_TEMPLATE.md (dev-infra approval)

@angular-robot angular-robot bot requested a review from devversion November 21, 2024 19:34
@kirjs kirjs force-pushed the docs-commit-message-guidelines branch 4 times, most recently from e444acc to 9cc414a Compare November 21, 2024 20:24
@kirjs
Copy link
Contributor Author

kirjs commented Nov 21, 2024

PTAL

@devversion devversion requested a review from jelbourn November 22, 2024 12:59
devversion
devversion reviewed Nov 22, 2024
View reviewed changes
JeanMeche
JeanMeche reviewed Nov 22, 2024
View reviewed changes
@kirjs kirjs force-pushed the docs-commit-message-guidelines branch 2 times, most recently from 56abf56 to 8031c40 Compare November 27, 2024 18:33
@kirjs kirjs added the target: patch This PR is targeted for the next patch release label Dec 12, 2024
@kirjs kirjs force-pushed the docs-commit-message-guidelines branch from 8031c40 to 2ae377f Compare February 3, 2025 21:47
@pullapprove pullapprove bot requested a review from thePunderWoman February 3, 2025 21:47
@kirjs kirjs force-pushed the docs-commit-message-guidelines branch from 2ae377f to e3f23f3 Compare February 3, 2025 21:50
@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Mar 4, 2025
@JeanMeche JeanMeche removed the request for review from jelbourn March 4, 2025 19:27
@mmalerba
Copy link
Contributor

mmalerba commented Mar 4, 2025

This PR was merged into the repository by commit 3902640.

The changes were merged into the following branches: main, 19.2.x

@mmalerba mmalerba closed this in 7ecaffc Mar 4, 2025
mmalerba pushed a commit that referenced this pull request Mar 4, 2025
@kirjs @mmalerba
docs: address comments (#58786)
390139e 
PR Close #58786
mmalerba pushed a commit that referenced this pull request Mar 4, 2025
@kirjs @mmalerba
docs: sync the scope lists and drop ve (#58786)
215ef78 
PR Close #58786
mmalerba pushed a commit that referenced this pull request Mar 4, 2025
@kirjs @mmalerba
docs: mention that log format makes it analyzable for changelog gener…
3902640 
…ation. (#58786)

PR Close #58786
mmalerba pushed a commit that referenced this pull request Mar 4, 2025
@kirjs @mmalerba
docs: move commit message guidelies to a separate file (#58786)
d30ea1b 
PR Close #58786
mmalerba pushed a commit that referenced this pull request Mar 4, 2025
@kirjs @mmalerba
docs: address comments (#58786)
114658c 
PR Close #58786
mmalerba pushed a commit that referenced this pull request Mar 4, 2025
@kirjs @mmalerba
docs: sync the scope lists and drop ve (#58786)
33a826b 
PR Close #58786
mmalerba pushed a commit that referenced this pull request Mar 4, 2025
@kirjs @mmalerba
docs: mention that log format makes it analyzable for changelog gener…
036ee75 
…ation. (#58786)

PR Close #58786
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Apr 4, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn left review comments

@JeanMeche JeanMeche JeanMeche left review comments

@devversion devversion devversion approved these changes

@thePunderWoman thePunderWoman thePunderWoman approved these changes

+1 more reviewer

@azimtechie azimtechie azimtechie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

7 participants

@kirjs @mmalerba @jelbourn @JeanMeche @thePunderWoman @devversion @azimtechie