Skip to content

fix(compiler-cli): support nested component declaration #58678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
yjaaidi wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(compiler-cli): support nested component declaration #58678

yjaaidi wants to merge 1 commit into from

Conversation

@yjaaidi
Copy link
Contributor

@yjaaidi yjaaidi commented Nov 15, 2024 •
edited
Loading

Example:

@Component(...)
class Outer {
  constructor() {
    @Component(...)
    class Inner {}
  }
}

Previous behavior was that IVy transformation was only applied to Inner, thus breaking Outer transformation.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@yjaaidi
fix(compiler-cli): support nested component declaration
5632f50 
```ts
@component(...)
class Outer {
  constructor() {
    @component(...)
    class Inner {}
  }
}
```

previous behavior was that IVy transformation was only applied to `Inner`, thus breaking `Outer` transformation.
@pullapprove pullapprove bot requested a review from devversion November 15, 2024 08:49
@yjaaidi yjaaidi force-pushed the fix/nested-component-declaration branch from 021e865 to 5632f50 Compare November 15, 2024 08:50
@pkozlowski-opensource pkozlowski-opensource added the area: compiler Issues related to `ngc`, Angular's template compiler label Nov 15, 2024
@ngbot ngbot bot added this to the Backlog milestone Nov 15, 2024
@yjaaidi
Copy link
Contributor Author

yjaaidi commented Nov 15, 2024

@eneajaho 🤫 I know where you live. 🙃

@devversion devversion added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Nov 15, 2024
@AndrewKushnir AndrewKushnir added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Nov 20, 2024
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Nov 20, 2024

Caretaker note: the presubmit contains some failures and some of them might be legit. We'd need to rerun tests and take a look at the failures.

@AndrewKushnir AndrewKushnir added state: blocked and removed action: merge The PR is ready for merge by the caretaker action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Nov 20, 2024
@thePunderWoman thePunderWoman marked this pull request as draft May 21, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alxhub alxhub alxhub approved these changes

@devversion devversion devversion approved these changes

Assignees

No one assigned

Labels

area: compiler Issues related to `ngc`, Angular's template compiler state: blocked target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

5 participants

@yjaaidi @AndrewKushnir @alxhub @devversion @pkozlowski-opensource