docs(docs-infra): change API reference list items order to top-down #58655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
detected: feature
hawkgs
commented
Nov 14, 2024
| @@ -29,7 +29,7 @@ <h3 [id]="group().id"> | |||
| class="docs-api-item-label" | |||
| aria-hidden="true" | |||
| /> | |||
| <span class="adev-item-title">{{ apiItem.title }}</span> | |||
| <span class="adev-item-title" [attr.title]="apiItem.title">{{ apiItem.title }}</span> | |||
There was a problem hiding this comment.
The title is set so that you can check it in case the text has been truncated.
JeanMeche
requested review from
JeanMeche
and removed request for
josephperrott
hawkgs
changed the title
hawkgs
force-pushed
the
docs/reorder-api-reference-list-items
branch
from
f0019b9 to
8614f17
Compare
angular-robot
bot
added
area: docs
hawkgs
force-pushed
the
docs/reorder-api-reference-list-items
branch
from
8614f17 to
e86e496
Compare
Change the order from left-right to top-down (columns) and additionally make columns equal width.
hawkgs
force-pushed
the
docs/reorder-api-reference-list-items
branch
from
e86e496 to
ebd6e6d
Compare
|
Deployed adev-preview for ebd6e6d to: https://ng-dev-previews-fw--pr-angular-angular-58655-adev-prev-b9j92i0k.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
JeanMeche
approved these changes
Jan 14, 2025
JeanMeche
added
action: merge
|
This PR was merged into the repository by commit 803358f. The changes were merged into the following branches: main, 19.0.x, 19.1.x |
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…ngular#58655) Change the order from left-right to top-down (columns) and additionally make columns equal width. PR Close angular#58655
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the order from left-right to top-down (columns) and additionally make columns equal width.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The list items in the API reference list groups have left-right alphabetical order while the vertical borders imply that the order should be top-down instead.
What is the new behavior?
The order is changed to top-down. Additionally, the column width is now equal which made it necessary to truncate the text.
Does this PR introduce a breaking change?