Skip to content

refactor(docs-infra): migrate adev to signal-based queries #58646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

refactor(docs-infra): migrate adev to signal-based queries #58646

wants to merge 1 commit into from

Conversation

sheikalthaf
Copy link
Contributor

Used migration schametic to migrate to signal based queries and little manual migration where setter is used

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from crisbeto November 14, 2024 04:35
@angular-robot angular-robot bot added the area: docs-infra Angular.dev application and infrastructure label Nov 14, 2024
@ngbot ngbot bot added this to the Backlog milestone Nov 14, 2024
@JeanMeche
Copy link
Member

Could you please rebase your PR ?

@JeanMeche JeanMeche added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Nov 28, 2024
@sheikalthaf
Copy link
Contributor Author

Could you please rebase your PR ?

@JeanMeche Resbased the PR.

@JeanMeche
Copy link
Member

It looks like this broke this app, it doesn't build anymore.

@JeanMeche
Copy link
Member

Can you please rebase the PR, thank you.

@sheikalthaf
Copy link
Contributor Author

@JeanMeche rebased the PR.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

Deployed adev-preview for a066ba6 to: https://ng-dev-previews-fw--pr-angular-angular-58646-adev-prev-u2rusn9i.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@JeanMeche
Copy link
Member

Hi, we still have 1 file with a conflict, can you please address that too !

@sheikalthaf sheikalthaf force-pushed the adev-query-migration branch from 62bbb4c to 24db7cd Compare March 5, 2025 18:00
@sheikalthaf
Copy link
Contributor Author

@JeanMeche rebased again and resolved conflicts.

@sheikalthaf sheikalthaf force-pushed the adev-query-migration branch from 24db7cd to ff4bddd Compare March 6, 2025 06:59
@sheikalthaf
Copy link
Contributor Author

@JeanMeche I have addressed the comments, can you review this PR

@sheikalthaf
refactor(docs-infra): migrate adev to signal-based queries
a066ba6 
Used migration schametic to migrate to signal based queries and little manual migration where setter is used
@sheikalthaf sheikalthaf force-pushed the adev-query-migration branch from ff4bddd to a066ba6 Compare March 25, 2025 04:14
@sheikalthaf
Copy link
Contributor Author

@JeanMeche can you review this PR.

@JeanMeche JeanMeche removed the request for review from crisbeto March 31, 2025 20:10
@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Mar 31, 2025
@JeanMeche JeanMeche added target: patch This PR is targeted for the next patch release and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 31, 2025
thePunderWoman pushed a commit that referenced this pull request Mar 31, 2025
@sheikalthaf @thePunderWoman
refactor(docs-infra): migrate adev to signal-based queries (#58646)
f15f411 
Used migration schametic to migrate to signal based queries and little manual migration where setter is used

PR Close #58646
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit f7a0b8e.

The changes were merged into the following branches: main, 19.2.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker adev: preview area: docs-infra Angular.dev application and infrastructure target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@sheikalthaf @JeanMeche @thePunderWoman