refactor(docs-infra): cleanup after render sequence in ReferenceScrollHandler
#58640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
area: docs-infra
JeanMeche
reviewed
Nov 14, 2024
arturovt
force-pushed
the
refactor/docs-analytics
branch
from
3de0b5d to
adf2c4b
Compare
arturovt
changed the title
error reporter only on clientReferenceScrollHandler
arturovt
changed the title
ReferenceScrollHandlerReferenceScrollHandler
Contributor
Author
|
@JeanMeche could you have a look? |
Member
|
Could you rebase it, so we can deploy it ? |
…llHandler` In this commit, we're replacing the provided injector in `afterNextRender` with a node injector because it was previously mistakenly passing an `EnvironmentInjector` in the `ReferenceScrollHandler`.
arturovt
force-pushed
the
refactor/docs-analytics
branch
from
adf2c4b to
bdfffc6
Compare
|
Deployed adev-preview for bdfffc6 to: https://ng-dev-previews-fw--pr-angular-angular-58640-adev-prev-le1vhosa.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
JeanMeche
added
action: merge
Contributor
|
This PR was merged into the repository by commit dc07a43. The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…llHandler` (angular#58640) In this commit, we're replacing the provided injector in `afterNextRender` with a node injector because it was previously mistakenly passing an `EnvironmentInjector` in the `ReferenceScrollHandler`. PR Close angular#58640
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we're replacing the provided injector in
afterNextRenderwith a node injectorbecause it was previously mistakenly passing an
EnvironmentInjectorin theReferenceScrollHandler.