Skip to content

Conversation

@arturovt
Copy link
Contributor

Prevents the RendererFactory2 from being resolved each time the tick runs, as it only needs to be requested once.

@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Nov 13, 2024
@ngbot ngbot bot added this to the Backlog milestone Nov 13, 2024
Prevents the `RendererFactory2` from being resolved each time the tick runs, as it only needs to be requested once.
@arturovt arturovt force-pushed the refactor/core-renderer-factory branch from 5ad2a8b to 160c0d8 Compare November 13, 2024 01:21
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Nov 13, 2024
@ngbot ngbot bot modified the milestone: Backlog Nov 13, 2024
@arturovt arturovt marked this pull request as ready for review November 13, 2024 01:23
@pullapprove pullapprove bot requested a review from AndrewKushnir November 13, 2024 01:24
@AndrewKushnir AndrewKushnir requested a review from alxhub November 15, 2024 00:20
@AndrewKushnir AndrewKushnir added target: patch This PR is targeted for the next patch release action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 15, 2024
@AndrewKushnir AndrewKushnir removed their request for review November 15, 2024 00:20
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Nov 15, 2024

@arturovt thanks for the improvement 👍

The change looks good, but I'm less familiar with this part of the codebase, so I'm adding @alxhub as a reviewer as well.

@pkozlowski-opensource pkozlowski-opensource removed the request for review from alxhub November 28, 2024 10:13
@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 28, 2024
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit a4b86b2.

The changes were merged into the following branches: main, 19.0.x

pkozlowski-opensource pushed a commit that referenced this pull request Nov 28, 2024
)

Prevents the `RendererFactory2` from being resolved each time the tick runs, as it only needs to be requested once.

PR Close #58618
@arturovt arturovt deleted the refactor/core-renderer-factory branch November 28, 2024 15:32
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants