Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cache fragment classes across different class loaders #87

Closed
wants to merge 2 commits into from
Closed

Don't cache fragment classes across different class loaders #87

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb6ec2e
Don't cache fragment classes across different class loaders
simonschiller Oct 14, 2020
e5f5916
Use Truth in tests
simonschiller Oct 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use Truth in tests
  • Loading branch information
@simonschiller
simonschiller committed Oct 15, 2020
commit e5f5916840904cab91884e3f525fde4a71d5a7dc
17 changes: 13 additions & 4 deletions fragment/fragment/src/test/java/androidx/fragment/app/FragmentFactoryTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

package androidx.fragment.app

import org.junit.Assert.assertEquals
import com.google.common.truth.Truth.assertWithMessage
import org.junit.Test

class FragmentFactoryTest {
Expand All @@ -27,7 +27,10 @@ class FragmentFactoryTest {
val classLoader = CountingClassLoader()
factory.instantiate(classLoader, TestFragment::class.java.name)
factory.instantiate(classLoader, TestFragment::class.java.name)
assertEquals(1, classLoader.loadCount)

assertWithMessage("Fragment class should only be looked up once")
.that(classLoader.loadCount)
.isEqualTo(1)
}

@Test
Expand All @@ -36,8 +39,14 @@ class FragmentFactoryTest {
val secondClassLoader = CountingClassLoader()
factory.instantiate(firstClassLoader, TestFragment::class.java.name)
factory.instantiate(secondClassLoader, TestFragment::class.java.name)
assertEquals(1, firstClassLoader.loadCount)
assertEquals(1, secondClassLoader.loadCount)

assertWithMessage("Fragment class should only be looked up once")
.that(firstClassLoader.loadCount)
.isEqualTo(1)

assertWithMessage("Fragment class should be looked up again for different class loaders")
.that(secondClassLoader.loadCount)
.isEqualTo(1)
}

class TestFragment : Fragment()
Expand Down