Use existing TestScope instead of creating a new one #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I managed to remove the usage of |
claraf3
approved these changes
Jun 6, 2023
|
Thanks for the clean up! |
veyndan
force-pushed
the
veyndan/rm-coroutineScope
branch
from
d7a8fcd
to
cab9e06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to see if I can elegantly remove the dependence of
PagingDataDifferTest.ktonMainDispatcherRule, without just inlining the class. Keeping track of all theCoroutineScopes for each test is difficult though, so I'm trying to slightly reduce it here (i.e., use theTestScopethat theSimpleDifferis invoked from, instead of creating a new one).Test: ./gradlew test connectedCheck