Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: FreeParameterExpression division #885

Merged
merged 4 commits into from
Feb 26, 2024
Merged

feat: FreeParameterExpression division #885

merged 4 commits into from
Feb 26, 2024

Conversation

speller26
Copy link
Member

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3769c77) to head (ad373f0).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #885   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          129       129           
  Lines         8602      8608    +6     
  Branches      1924      1925    +1     
=========================================
+ Hits          8602      8608    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AbeCoull
Copy link
Contributor

Can we add a test with div by 0

@speller26 speller26 merged commit ac47de8 into main Feb 26, 2024
24 checks passed
@speller26 speller26 deleted the truediv branch February 26, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants