Fix Video control bugs, Add architecture documentation, project restructure #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
codedentwickler
commented
Mar 28, 2018
•
codedentwickler
commented
- fix: Ensure video control stays visible while the video is paused. fixes video player: fading of UI elements should start after play starts #60
- feat: Add project structure description in ARCHITECTURE.md
- feat: Create sub-modules for each user story in Presentation
added 2 commits
March 28, 2018 02:14
refactor: Create sub-modules for each simple user story in Presentation. This pattern is known as package by feature.
codedentwickler
changed the title
|
Good job. Works nicely. In the future, I would suggest/advice not to mix multiple things in a given PR. -- .g. a fix mixed with unrelated documentation changes, etc. |
|
Noted. Thanks for the feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.