Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add logs_bloom #768

Merged
merged 2 commits into from
Oct 10, 2024
Merged

feat: add logs_bloom #768

merged 2 commits into from
Oct 10, 2024

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Oct 10, 2024 •
edited
Loading

DaniPopes
DaniPopes requested changes Oct 10, 2024
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs clippy

crates/primitives/src/log/mod.rs Outdated
Comment on lines 11 to 14
bloom.m3_2048(log.address.as_slice());
for topic in log.topics() {
bloom.m3_2048(topic.as_slice());
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bloom.accrue_log

@DaniPopes DaniPopes merged commit 0441d79 into main Oct 10, 2024
29 checks passed
@DaniPopes DaniPopes deleted the matt/add-logs-bloom branch October 10, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @DaniPopes