Bug fix: resolve initialization script paths starting with ~ & release v0.5.1 #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using only `.resolve()` means a path like `~/.my_startup.sql` resolves to `/Users/me/~/.my_startup.sql` which does not exist. Using `.expanduser.resolve()` means the path properly resolves to `/Users/me/.my_startup.sql`
alexmalins
added a commit
to alexmalins/harlequin
that referenced
this pull request
Sep 21, 2024
Using only `.resolve()` means a path like `~/.my_startup.sql` resolves to `/Users/me/~/.my_startup.sql` which does not exist. Using `.expanduser.resolve()` means the path properly resolves to `/Users/me/.my_startup.sql`. cf. alexmalins/harlequin-databricks#16
8 tasks
alexmalins
added a commit
to alexmalins/harlequin
that referenced
this pull request
Sep 21, 2024
Using only `.resolve()` means a path like `~/.my_startup.sql` resolves to `/Users/me/~/.my_startup.sql` which does not exist. Using `.expanduser.resolve()` means the path properly resolves to `/Users/me/.my_startup.sql`. cf. alexmalins/harlequin-databricks#16
tconbeer
pushed a commit
to tconbeer/harlequin
that referenced
this pull request
Sep 25, 2024
Using only `.resolve()` means a path like `~/.my_startup.sql` resolves to `/Users/me/~/.my_startup.sql` which does not exist. Using `.expanduser.resolve()` means the path properly resolves to `/Users/me/.my_startup.sql`. cf. alexmalins/harlequin-databricks#16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/fix?
Fix bug to properly resolve initialization script paths starting with
~(i.e. user's home dir) supplied to--init-path.Using only
.resolve()means a path like~/.my_startup.sqlresolves to/Users/me/~/.my_startup.sqlwhich does not exist.Using
.expanduser.resolve()means the path properly resolves to/Users/me/.my_startup.sql.Fixes Issue
Other comments?