product_usability: seller_id can not be store as muti-company will be broken #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bealdav
approved these changes
May 31, 2024
|
Good catch |
… broken do not store the field as shared product can have different supplier depending on the company logged Use compute as related will always pick the first one whatever the company logged
sebastienbeau
force-pushed
the
14.0-fix-product_usability
branch
from
1f696a7 to
0fa2024
Compare
alexis-via
reviewed
Feb 17, 2025
| # searching on the first line of a o2m is not that easy | ||
| # So we search all potential matching products | ||
| # Then we filter on the seller_id | ||
| records = self.search([("seller_ids.partner_id", operator, value)]) |
There was a problem hiding this comment.
BOUM ! CRASH !
seller_ids.name and not seller_ids.partner_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In multi company each company can have it own supplier with shared product, in that case supplier id are different
#211