Improve actor telemetry types #7439
Merged
+51
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
Dec 27, 2024
| /// <summary> | ||
| /// Overrideable in order to support issues such as https://github.com/petabridge/phobos-issues/issues/82 | ||
| /// </summary> | ||
| protected virtual ActorRestarted CreateActorRestartedEvent(Exception cause) |
There was a problem hiding this comment.
Add override for ActorRestarted
| /// <summary> | ||
| /// A type name override for the actor | ||
| /// </summary> | ||
| public string ActorTypeOverride { get; } |
There was a problem hiding this comment.
Add new actor type name override property
| } | ||
|
|
||
| // Create ActorTelemetryEvent messages for the following events: starting an actor, stopping an actor, restarting an actor | ||
| public sealed class ActorStarted : IActorTelemetryEvent | ||
| { | ||
| internal ActorStarted(IActorRef subject, Type actorType) | ||
| public ActorStarted(IActorRef subject, Type actorType, string? actorTypeOverride = null) |
There was a problem hiding this comment.
Make actor telemetry message constructors public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):