Akka.Cluster.Sharding: harden event-sourced RememberEntities infrastructure against transient Akka.Persistence failures
#7401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
close akkadotnet#7399 - wrapped the RememberEntities coordinator and shard-store inside
Aaronontheweb
changed the title
RememberEntities infrastructure against transient Akka.Persistence failures
Aaronontheweb
commented
Dec 2, 2024
| @@ -29,7 +30,15 @@ public EventSourcedRememberEntitiesProvider(string typeName, ClusterShardingSett | |||
| /// <returns></returns> | |||
| public Props ShardStoreProps(string shardId) | |||
| { | |||
| return EventSourcedRememberEntitiesShardStore.Props(TypeName, shardId, Settings); | |||
| var backoffOptions = Backoff.OnStop( | |||
There was a problem hiding this comment.
Wraps the ShardStore inside a BackoffSupervisor - uses the same tuning parameters as the shard itself.
| @@ -39,7 +48,14 @@ public Props ShardStoreProps(string shardId) | |||
| /// <returns></returns> | |||
| public Props CoordinatorStoreProps() | |||
| { | |||
| return EventSourcedRememberEntitiesCoordinatorStore.Props(TypeName, Settings); | |||
| var backoffOptions = Backoff.OnStop( | |||
There was a problem hiding this comment.
Wraps the RememberEntitiesCoordinator inside a BackoffSupervisor - uses the same tuning parameters as the ShardingCoordinator for backoff.
| @@ -93,7 +93,7 @@ public RememberEntityStarter( | |||
| Timers.StartPeriodicTimer("retry", ResendUnAcked.Instance, settings.TuningParameters.RetryInterval); | |||
| } | |||
|
|
|||
| public ITimerScheduler Timers { get; set; } | |||
| public ITimerScheduler Timers { get; set; } = null!; | |||
There was a problem hiding this comment.
Fixed a nullability warning here. This value always gets set by the Akka.NET infrastructure.
This was referenced Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
resolved #7399
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):